Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C676C636CB for ; Sun, 18 Jul 2021 06:42:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A834D6108B for ; Sun, 18 Jul 2021 06:42:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A834D6108B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m50V3-0003M8-Fr for qemu-devel@archiver.kernel.org; Sun, 18 Jul 2021 02:42:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m50SF-0001wb-7Z; Sun, 18 Jul 2021 02:39:11 -0400 Received: from ozlabs.org ([203.11.71.1]:35255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m50SC-0006xR-Ns; Sun, 18 Jul 2021 02:39:11 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4GSFgR2rFfz9sW8; Sun, 18 Jul 2021 16:38:59 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1626590339; bh=aECc5KNRVEVSzpe6mST2Ev9xnwC1DNHIlG73euO/B8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nS2/3KZNMnUL9shmY9cZpJEHgr88mmekCvLdWtG0yZf1VyEOv/vVet7gcBqPc8CeE X0rhJw79TabOA9jQJIXbQHRwi338qUCyr31smBtuYtLVAXpCbLv/9YCC4r1yholSk8 giNS54MomxGZ3haB7sjNYWmHmTqalSqKXAdm/dEs= Date: Sun, 18 Jul 2021 16:24:28 +1000 From: David Gibson To: BALATON Zoltan Subject: Re: [PATCH 1/2] ppc/pegasos2: Fix spurious warning with -bios Message-ID: References: <483ac599a1407b766179aaea2794aed60cc09f53.1626367844.git.balaton@eik.bme.hu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dKK++Xggv2KLmmCB" Content-Disposition: inline In-Reply-To: <483ac599a1407b766179aaea2794aed60cc09f53.1626367844.git.balaton@eik.bme.hu> Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --dKK++Xggv2KLmmCB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 15, 2021 at 06:50:44PM +0200, BALATON Zoltan wrote: > The -append option is currently not compatible with -bios (as we don't > yet emulate nvram so we can only put it in the environment with VOF). > Therefore a warning is printed if -append is used with -bios but > because the default value of kernel_cmdline seems to be an empty > string instead of NULL this warning was printed even without -append > when -bios is used. Only print warning if -append is given. >=20 > Signed-off-by: BALATON Zoltan Applied to ppc-for-6.1. > --- > hw/ppc/pegasos2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c > index 9fad1854b1..b8ce859f1a 100644 > --- a/hw/ppc/pegasos2.c > +++ b/hw/ppc/pegasos2.c > @@ -191,7 +191,7 @@ static void pegasos2_init(MachineState *machine) > warn_report("Option -kernel may be ineffective with -bios."); > } > } > - if (machine->kernel_cmdline && !pm->vof) { > + if (!pm->vof && machine->kernel_cmdline && machine->kernel_cmdline[0= ]) { > warn_report("Option -append may be ineffective with -bios."); > } > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --dKK++Xggv2KLmmCB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmDzyRoACgkQbDjKyiDZ s5LexA/+PtuNb3wbMIRhMH46A9YebP1Kkw/gmXPRF7brC8VL8qKD+GdqknEFvnZb RxxnZhZcvVaNUCNibVLChNR57saBEjaytev2PrA8pIcCgzTBqVSwJNfExQSfLrw0 KKepQswMXqOApOeuLlxTYiHxqvrBu045pv7KTYuN+MNr2iGjVKYgwprCRogjr7iz 0z80H35Br+Sdljf8xF7wWO5XqQkP89P0ebM8EY1Pdf2O4et07xOna2zhd0M5IXPl dQavwTRZ4l+lDG24cfMAusgDd8OocXNLKSuc9htY4KEPAhbxAjnG+UZgZrm/u7O4 ETfDSYOF3BF/fofF0o/7ZR8BkNMuCZeV8sgiPRrLW9VBZhk28S7x3IqWY3N+ZxQd s1c6b9XfxLSxiueJpbPbXeGAaPELhMy+b8/g2R/MnuzRzy76tOxE3d4XFXExtx9c emBxrCjmo0ilOWSVWYs3otp4jvxbonJXrcD25upIKHCDwnzvSHzWRgzIkKlG5hjm ekhN/LD9+Nwu9ds4DIKz7IujNWPJqCXQ0S/oyvgYqdR9O5wZV0Q6U6C9kp+dM2gy 36MCuCP1ZP91cSh2f+Mo4YqB2G6ZQagilRlps+gkT6rBDVeGkmFqrxoD0BeOqHcw AaHajz9TjFmQA6lm3JhMtYXfoaji5Iw34aH/DLjGd5Zzl7ez0Wg= =nhMd -----END PGP SIGNATURE----- --dKK++Xggv2KLmmCB--