Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F97C12002 for ; Mon, 19 Jul 2021 03:41:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C4FA6101D for ; Mon, 19 Jul 2021 03:41:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C4FA6101D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5K9h-0003Kl-9B for qemu-devel@archiver.kernel.org; Sun, 18 Jul 2021 23:41:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5K6Q-0001Ch-33; Sun, 18 Jul 2021 23:37:58 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:59193) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5K6L-0002wA-6C; Sun, 18 Jul 2021 23:37:57 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4GSnbv1KyHz9sWl; Mon, 19 Jul 2021 13:37:46 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1626665867; bh=HRiikgjK21c0gpyuGwqoXyX7EaLskNkA/03GbkFOb/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ClogegyIuzMDrtRRH7a5Xu2xSEPSWfFhsiOD8etLye8aQHAsGl4PFd23LAzWwA5BE D9rtVkCeHyzsbyHaFi7yOuTxgyCuqJ/TlDDKBWYx+kLBT8sSp5NOP+qoE25rjywArP PrJ1i0T3Hp6oMuGitnluW+sqfawvlYChPEpQa5Ck= Date: Mon, 19 Jul 2021 12:14:33 +1000 From: David Gibson To: BALATON Zoltan Subject: Re: [PATCH 2/2] i2c/smbus_eeprom: Add feature bit to SPD data Message-ID: References: <19d42ade295d5297aa624a9eb757b8df18cf64d6.1626367844.git.balaton@eik.bme.hu> <20210718180329.GM3431@minyard.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H0njV8DADKRUn0cq" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --H0njV8DADKRUn0cq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 18, 2021 at 10:39:16PM +0200, BALATON Zoltan wrote: > On Sun, 18 Jul 2021, Corey Minyard wrote: > > On Thu, Jul 15, 2021 at 06:50:44PM +0200, BALATON Zoltan wrote: > > > Add the differential clock input feature bit to the generated SPD > > > data. Most guests don't seem to care but pegasos2 firmware version 1.2 > > > checks for this bit and stops with unsupported module type error if > > > it's not present. Since this feature is likely present on real memory > > > modules add it in the general code rather than patching the generated > > > SPD data in pegasos2 board only. > > >=20 > > > Signed-off-by: BALATON Zoltan > >=20 > > I checked this all out and it looks correct to me. I can take it in my > > tree, if necessary. Feature freeze is in two days, so probably not for > > 6.1, though it could be pushed into there if its needed in 6.1. > >=20 > > Or: > >=20 > > Acked-by: Corey Minyard >=20 > Thanks. As this fixes pegasos2 ROM 1.2 that some users may find instead of > the 1.1 version I consider this a bugfix not a feature and would like to = get > merged for 6.1 if possible (hopefully can be in David's tree with the oth= er > patch that's also a bugfix) because that way it won't happen that some us= ers > will get problems if they find the wrong ROM. With this patch both versio= ns > available on line work so there should be no problem for anyone. Other > firmware ROMs don't seem to care so they're unlikely to break and the only > machines using it now are pegasos2, sam460ex and fuloong2e and only when > using firmware ROM so this does not need to wait until 6.2 I think as 6.1= is > the first version pegasos2 is available and it would be nice to get it > working well in the first version. I'll accept the argument that this is a bugfix, and reasonable to merge at least early in the freeze. So, I've merged it into my tree with Corey's ack. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --H0njV8DADKRUn0cq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmD04AkACgkQbDjKyiDZ s5JBig//cyozbLvcxM3EeiZj1MKDfoZZQ21dqy7iwsqI10gB9qXdVBa6RljI/W+P 4Mc4XrrICoEOykZgMXX4eVVivO3kIYRe+LpRiZzUM19vpjuiNtzw/JrKPnjYM8Si h3OkEPXG4AB4BkV3vuyC7JyFWXZzW540+RAlXEGNnHi8BCwSFjQyxQ6qbh7xNTry EQuFLRyuoRWbnYKoUdzkTuirhOJOxYY6lYrBngVL2S0MMaDcOKTOYDqv7A91+IMe pP7S07KR0/FTkxAcxUM9/9/4yVwJc91TSqMTZhuU0v7XQR5/YucGd3sy8y9czl7v e0Qt4QPdEZOWm0N4kmmN4rIGjU7/1fAHANs6YCeaK9z4oIbF8lzBAp6qfhxId16i F8NLJgB3Exbisu0s7BUM6sczHfU6UXq7sEBAc1QEnbfzk7ryINvVk+F7v+smE29C JUtz159FaPzq8zzHHpjUVp4tq5g95yzF2mDVMpNrjGygbL+tBajXaSqZ3wTHR93m BagGv4mTr3NrGibdZ45mcF2tKwpn7+c+6eM0U6XHa4e+lTaDSvVdm4PA2IkgoxGP 518gXbtK0JWfDpERPWdcynpBiEQSdDOAk3TKmc1n3Yzm/e8ZwZTUntGJXc553mqc CriaSFVUW3CVH3Oz+bneV725GspxQFrCdGzxBhjbdw+7A7U6U38= =jvqG -----END PGP SIGNATURE----- --H0njV8DADKRUn0cq--