Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D6E5C4338F for ; Sat, 7 Aug 2021 14:20:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A400A610FC for ; Sat, 7 Aug 2021 14:20:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A400A610FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yLdGrCOQ7RUIBPmXmBf3/UfUuEtqmgzhZlNtsXkI5uI=; b=LFqKX+gCnuxf2G 3TKHdEweaESOo0jKSDdeu9K+px0RxZlqDuAlQ1k+9Nykuwui9HpzOGS8k0bOHvnukuILbMYgbUqI+ PfvamWqiGlWStf4IDN2cs6aKoXOzXbAf92+HHAAAAZQmfnOp+NaZYcljA7C+frbgiQcc73rDiz9kk E0VJJnaZMqjjUXMM19hV7EuFg1Hd8Yc5h7XV+jsynPWGj3T/a8XPLkw1BZv0SnLak6RO7xUiGlcaE Caus6nqxWzsCsQi9ETklR/KUEl+sFNsr4KEI9E/w12UiDswaYzN+1OApJyErJ8Vf2C+9T75HLK2RD +tls9fvuJJVX6ir5/vOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCN9H-00Es0E-UM; Sat, 07 Aug 2021 14:18:04 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCN9E-00Erzu-Rm for linux-arm-kernel@lists.infradead.org; Sat, 07 Aug 2021 14:18:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Xk437ZK+XzJVD1Kge5a4sgFw8KUmaw3G46w6ax86i/I=; b=GmyXZz2H5ziYlbr6jxmAVr9z2Y P7ytkcrsbv2z6cjobDfvcCyFvs77S64MsD3oo7tOiBy/uKsiiKRMcuxf7dP+QyrZfg3IWz3iTqiuf 3VFAviN9Pn7cGIe/ozCzi0ZLdkJNqR++0M3v0zqsWxJslY2hI2EwSxMdAk37Zty48D1E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mCN8y-00GVAU-RT; Sat, 07 Aug 2021 16:17:44 +0200 Date: Sat, 7 Aug 2021 16:17:44 +0200 From: Andrew Lunn To: Michael Walle Cc: Daniel Golle , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH] ARM: kirkwood: add missing for ETH_ALEN Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210807_071800_944540_2D4E0148 X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > What kernel is this? I've just tested with this exact commit as > base and it compiles just fine. > > I'm not saying including the file is wrong, but it seems it isn't > needed in the upstream kernel and I don't know if it qualifies for > the stable queue therefore. I would like to see a reproducer for mainline. Do you have a kernel config which generates the problem. The change itself does seems reasonable, so if we can reproduce it, i would be happy to merge it for stable. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel