Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9ED7C4338F for ; Wed, 18 Aug 2021 17:40:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67900610FE for ; Wed, 18 Aug 2021 17:40:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 67900610FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C37B96E83F; Wed, 18 Aug 2021 17:40:13 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 247416E83F for ; Wed, 18 Aug 2021 17:40:11 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 4f7111fd-004b-11ec-aa7e-0050568cd888; Wed, 18 Aug 2021 17:39:59 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id E263B194B06; Wed, 18 Aug 2021 19:40:20 +0200 (CEST) Date: Wed, 18 Aug 2021 19:40:08 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Robert Foss Cc: a.hajda@samsung.com, narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, xji@analogixsemi.com, pihsun@chromium.org, tzungbi@google.com, hsinyi@chromium.org, drinkcat@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] drm/bridge: anx7625: Propagate errors from sp_tx_edid_read() Message-ID: References: <20210818171318.1848272-1-robert.foss@linaro.org> <20210818171318.1848272-2-robert.foss@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818171318.1848272-2-robert.foss@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Robert, On Wed, Aug 18, 2021 at 07:13:18PM +0200, Robert Foss wrote: > During the sp_tx_edid_read() call the return value of sp_tx_edid_read() > is ignored, which could cause potential errors to go unhandled. > > All errors which are returned by sp_tx_edid_read() are handled in > anx7625_get_edid(). > > Signed-off-by: Robert Foss > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index ea414cd349b5c..abc8db77bfd36 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -845,8 +845,11 @@ static int sp_tx_edid_read(struct anx7625_data *ctx, > if (g_edid_break == 1) > break; > > - segments_edid_read(ctx, count / 2, > - pblock_buf, offset); > + ret = segments_edid_read(ctx, count / 2, > + pblock_buf, offset); > + if (ret < 0) > + return ret; > + This could be just "if (ret)". Same goes for the next case. With or without this simplification: Reviewed-by: Sam Ravnborg I assume you will apply the patches. Sam > memcpy(&pedid_blocks_buf[edid_pos], > pblock_buf, > MAX_DPCD_BUFFER_SIZE); > @@ -863,8 +866,11 @@ static int sp_tx_edid_read(struct anx7625_data *ctx, > if (g_edid_break == 1) > break; > > - segments_edid_read(ctx, count / 2, > - pblock_buf, offset); > + ret = segments_edid_read(ctx, count / 2, > + pblock_buf, offset); > + if (ret < 0) > + return ret; > + > memcpy(&pedid_blocks_buf[edid_pos], > pblock_buf, > MAX_DPCD_BUFFER_SIZE); > -- > 2.30.2