Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93053C433EF for ; Tue, 12 Oct 2021 03:24:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CB2D60F43 for ; Tue, 12 Oct 2021 03:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232238AbhJLD0K (ORCPT ); Mon, 11 Oct 2021 23:26:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232098AbhJLD0J (ORCPT ); Mon, 11 Oct 2021 23:26:09 -0400 Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7325C061570 for ; Mon, 11 Oct 2021 20:24:08 -0700 (PDT) Received: by mail-ua1-x933.google.com with SMTP id j8so7664719uak.9 for ; Mon, 11 Oct 2021 20:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=05JfAVZ+h7mE5tV9xgtjhMjstYtcv3IxzoXo5DOS8Bc=; b=XGM4AalAX1+8HICtDV3dnndPWh3DVI6pEv6JOSiquVEJ1SblB3Wh3SA3h/YwHdvHIw TFeHRn7DVGGovIQm7GiSEo3TTWu35UdhamQiNmKjFLeewc2jMEfCNBXcewwbWg3pV/RE aZr/IatgS7PASkKmeIKcom7ExlE6sslE3J1fMgCoBWeYfE1k1KOtcLvXJlYdCyYbOgai Y3zwAT51islrFirLE3tZfvAVm3kIk07XXO+eyI9isVaswWeHdttF+IyKI5PCSz6pQJgB u6MIriWEatRnfAGsuACo/ebRYPdGwQ1MhyjI2KZoOS97VFWWq+Hds8CNDsG6ZQ2R+iKX 1Ziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=05JfAVZ+h7mE5tV9xgtjhMjstYtcv3IxzoXo5DOS8Bc=; b=B8wtgY/37QOblxbwsTSnQ8I0tQ1MN9NyB5a07kvxE2fAweQOjAj+RZvbmiAli39jAQ PJ4D2Rwq66/wERFdzsMTe61Gfptdpp+0EHi7OKru9KZMg5WFfPA72YU1h5HRqypQ1AJe gyZOksCv9y8EG2owS/k6AGOhqHmZEpSlERbu1kSx4BRhwiuBt6f/gnAdsl+h7+/PzYz3 MpfWkb6mCcuxcdEOveNLPz+GG4PQRnORcIHIS+0qK5Ristt5F57s5VKiodIFRZ9IFhd/ rfsK8z5DbNQ6j06+kbrpLcwi07ORtXFaMbWWjmtkf12058SrOkMKwEryGFGm19Zncitw psLQ== X-Gm-Message-State: AOAM5312KrE+oYT4LdQp5a4c+iVVS9kG1xu+9UTsorhnn5wq58oSp3j+ Bna8Km4nqcOoTahGQOQurZO58g== X-Google-Smtp-Source: ABdhPJz6WgBYu+RuHEVXvxf+e7LXJGJEwNqVoWCRKe+0ncKGBgDXKyCoe2oWAuKnrdznsGHQS8IaDw== X-Received: by 2002:a67:d48a:: with SMTP id g10mr27580438vsj.3.1634009047974; Mon, 11 Oct 2021 20:24:07 -0700 (PDT) Received: from fedora ([2803:9800:98c2:8470:9f4:8e2a:88e5:ec01]) by smtp.gmail.com with ESMTPSA id p8sm4317509vke.11.2021.10.11.20.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 20:24:06 -0700 (PDT) Date: Tue, 12 Oct 2021 00:24:02 -0300 From: Ezequiel Garcia To: Mikhail Rudenko Cc: linux-media@vger.kernel.org, Helen Koike , Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: rockchip: rkisp1: use device name for debugfs subdir name Message-ID: References: <20211010175457.438627-1-mike.rudenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211010175457.438627-1-mike.rudenko@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sun, Oct 10, 2021 at 08:54:57PM +0300, Mikhail Rudenko wrote: > While testing Rockchip RK3399 with both ISPs enabled, a dmesg error > was observed: > ``` > [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present! > ``` > > Fix it by using the device name for the debugfs subdirectory name > instead of the driver name, thus preventing name collision. > > Signed-off-by: Mikhail Rudenko Reviewed-by: Ezequiel Garcia Thanks! > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > index 7474150b94ed..560f928c3752 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > @@ -426,7 +426,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1) > { > struct rkisp1_debug *debug = &rkisp1->debug; > > - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL); > + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL); > debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir, > &debug->data_loss); > debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir, > -- > 2.33.0 >