Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76D27C433EF for ; Sun, 17 Oct 2021 17:33:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E734060FD9 for ; Sun, 17 Oct 2021 17:33:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E734060FD9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 059756E5D1; Sun, 17 Oct 2021 17:33:11 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F35C6E5D1 for ; Sun, 17 Oct 2021 17:33:09 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 4bbf31ab-2f70-11ec-9c3f-0050568c148b; Sun, 17 Oct 2021 17:33:09 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 45709194B21; Sun, 17 Oct 2021 19:33:15 +0200 (CEST) Date: Sun, 17 Oct 2021 19:33:05 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Julian Braha Cc: thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm/panel/tianma-tl057fvxp01: add panel for Motorola Moto G6 Message-ID: References: <20210808200854.187648-1-julianbraha@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210808200854.187648-1-julianbraha@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Julian, On Sun, Aug 08, 2021 at 04:08:54PM -0400, Julian Braha wrote: > This is a 5.7" 2160x1080 panel found on the Motorola Moto G6. > There may be other smartphones using it, as well. > > Signed-off-by: Julian Braha Sorry for coming back so late. Driver looks good and is almost ready to apply. One detail you need to fix, see below. Sam > --- > + > +static const struct of_device_id tianma_tl057fvxp01_of_match[] = { > + { .compatible = "tianma,tl057fvxp01" }, > + { /* sentinel */ } > +}; The compatible needs to be documented before I can include the driver in the kernel. Please add a patch that document the compatible - maybe as a new binding file but preferably as part of one of the existing binding files. Sam