Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A99C433F5 for ; Thu, 28 Oct 2021 15:24:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15CE3610C8 for ; Thu, 28 Oct 2021 15:24:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15CE3610C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E83E6E994; Thu, 28 Oct 2021 15:24:17 +0000 (UTC) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD5C76E994 for ; Thu, 28 Oct 2021 15:24:15 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id z14so10878211wrg.6 for ; Thu, 28 Oct 2021 08:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=tv2oay0BJwn9J4qOktOFDlX3UCtKb/zY1x+VfaeHlvA=; b=PqYOXRiakc6910z5E0b0jhDIseWTs/ati5gqTU2+KetsIuYl+LCKRSuA9DnUF04DTG a3Tb+crbiPS8wQY10mICkzNWU3BwKVElwV0Xu51Np4GyP/K37nlp6VuGsNB/3vBr+hWO wPGvjGXCGyoRsCmBnz3uBRYuNqYbbaK562IXM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=tv2oay0BJwn9J4qOktOFDlX3UCtKb/zY1x+VfaeHlvA=; b=a9B5TkbEJ3hFtsPGteHDJoinKnm4ZaifFnX3aaU5JByIJ/uoK/4er72vrFuO2+xe+r KBqpsBLy2CKK/rTuyGZv2+PqCcHhy5gTVNHc28aH3G9vC6JWuH54i2xEDiqEE3FkxMKT tRB0Yo51sAnP1/S5moWlkJOjg49PCbGT/ka4vK5VdOSkNLCPDQeI3RkYIvspVLuF/oFZ gtyU6p/A3x0NkAYgWo3oo2sOqWuAHG9wy7GtRdlPJ84Juak7HAXKgG78EkIzdoHFilAW w0r0HjlD3LHwXn0o/PpwNUdoe88N+Pzp2XIWIqMlrHBoCe1viCfFAYx6j01aVsmDSbBr XDog== X-Gm-Message-State: AOAM5313jk5mmc+CYaj2jfhlZWA0NoSWLgQ6/6Gfs4uTVnK6gimcErYl /gD7lgpJguLWRlz7rzOQHu2b+cZSHcNRtw== X-Google-Smtp-Source: ABdhPJyoOV0TArYwFSys/pEgfWguKwZVtXaxh2rVmLpBFDFOkvNOyx2RNdVA2wiYCMc2yoJTXJQT8A== X-Received: by 2002:a05:6000:15cc:: with SMTP id y12mr6643371wry.333.1635434654399; Thu, 28 Oct 2021 08:24:14 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id n68sm6474347wmn.13.2021.10.28.08.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 08:24:13 -0700 (PDT) Date: Thu, 28 Oct 2021 17:24:11 +0200 From: Daniel Vetter To: Javier Martinez Canillas Cc: Arnd Bergmann , Jani Nikula , Daniel Vetter , Kees Cook , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Arnd Bergmann , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel , Linux Kernel Mailing List Subject: Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency Message-ID: Mail-Followup-To: Javier Martinez Canillas , Arnd Bergmann , Jani Nikula , Kees Cook , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Arnd Bergmann , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel , Linux Kernel Mailing List References: <20210927142816.2069269-1-arnd@kernel.org> <202109270923.97AFDE89DB@keescook> <878ryeit9i.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-8-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 27, 2021 at 03:19:34PM +0200, Javier Martinez Canillas wrote: > On 10/27/21 14:18, Arnd Bergmann wrote: > > [snip] > > > Right, how about this change on top? > > > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -117,9 +117,8 @@ config DRM_DEBUG_MODESET_LOCK > > > > config DRM_FBDEV_EMULATION > > bool "Enable legacy fbdev support for your modesetting driver" > > - depends on DRM > > - depends on FB=y || FB=DRM > > - select DRM_KMS_HELPER > > + depends on DRM_KMS_HELPER > > + depends on FB=y || FB=DRM_KMS_HELPER > > select FB_CFB_FILLRECT > > select FB_CFB_COPYAREA > > select FB_CFB_IMAGEBLIT > > > > That would probably make it work for DRM=y, FB=m, DRM_KMS_HELPER=m, > > but it needs more randconfig testing, which I can help with. > > Looks good to me as well. > > Reviewed-by: Javier Martinez Canillas Is the mess I created sorted now, or something for me to do? I'm terribly burried in stuff :-/ -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch