Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07366C433F5 for ; Tue, 23 Nov 2021 18:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239850AbhKWSm6 (ORCPT ); Tue, 23 Nov 2021 13:42:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:45176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239576AbhKWSm6 (ORCPT ); Tue, 23 Nov 2021 13:42:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 942C960231; Tue, 23 Nov 2021 18:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637692790; bh=q3yTpI4Q0rJx+kU/+OTPxy33tA2d4yqHAfMRilwZMg4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MM9YMA72jOvSCzle+RHsGe4DSeO/VRQquvB0BUUj6TsPlARDrB2jOYUbK6SxyFpss rEMBwNXn7MF+4FdJDIBgNH11tPylm13nnsMu0+d4g37U1tCnK0jLUnmbt7aViBk1b4 VEGVs6kVWTSnsjVxthzedxe995A5GvXWxXWRo2Y0= Date: Tue, 23 Nov 2021 19:39:47 +0100 From: Greg Kroah-Hartman To: Paul Gortmaker Cc: linux-edac@vger.kernel.org, Borislav Petkov , Tony Luck , Tim Small , Andrew Morton , Mauro Carvalho Chehab , Douglas Thompson Subject: Re: [PATCH] EDAC/443bxgx: drop never enabled driver marked as broken for 14 years. Message-ID: References: <20211123150646.47676-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211123150646.47676-1-paul.gortmaker@windriver.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Nov 23, 2021 at 10:06:46AM -0500, Paul Gortmaker wrote: > In commit 28f96eeafc89 ("drivers/edac-new-i82443bxgz-mc-driver: mark > as broken") this driver got added "depends on BROKEN", indicating: > > It will claim the PCI devices from under intel_agp.ko's feet. > Greg is brewing some fix for that. I have no idea what I was brewing up then :) > That was 14 years ago. It is safe to say that 99.9% of the original > 440BX/GX chipset systems have long been retired anyway. So there is no > point in carrying around this driver any longer and making tree wide > changes to it. > > In fact, the driver was added in v2.6.23-rc1~321 and then marked broken > in the following commit above - v2.6.23-rc1~320 and hence was never ever > enabled in mainline to begin with. > > Cc: Borislav Petkov > Cc: Tony Luck > Cc: Tim Small > Cc: Andrew Morton > Cc: Mauro Carvalho Chehab > Cc: Douglas Thompson > Cc: Greg Kroah-Hartman > Signed-off-by: Paul Gortmaker Acked-by: Greg Kroah-Hartman thanks for the cleanup. greg k-h