Content-Type: multipart/mixed; boundary="===============4628767821686245455==" MIME-Version: 1.0 From: Heiko Carstens To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 2/2] s390/kexec: fix kmemleak Date: Thu, 18 Nov 2021 09:53:31 +0100 Message-ID: In-Reply-To: <20211118071327.GF21646@MiWiFi-R3L-srv> List-Id: --===============4628767821686245455== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Nov 18, 2021 at 03:13:27PM +0800, Baoquan He wrote: > On 11/18/21 at 05:46am, kernel test robot wrote: > > arch/s390/kernel/machine_kexec_file.c: In function 'arch_kimage_file= _post_load_cleanup': > > >> arch/s390/kernel/machine_kexec_file.c:332:9: error: implicit declara= tion of function 'kvfree'; did you mean 'vfree'? [-Werror=3Dimplicit-functi= on-declaration] > > 332 | kvfree(image->arch.ipl_buf); > > | ^~~~~~ > > | vfree > = > OK, kvfree is not wrong, seems vfree is more appropriate since it's > clear the ipl_buf is allocated with zvalloc() in ipl_report_finish(). > = > Hi Heiko, > = > Could you help modify the code in your tree or append below patch to > mute the lkp complaint? Sorry for the inconvenience. ... > arch/s390/kernel/machine_kexec_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/arch/s390/kernel/machine_kexec_file.c b/arch/s390/kernel/mac= hine_kexec_file.c > index 7f51837e9bc2..351a7ff69a43 100644 > --- a/arch/s390/kernel/machine_kexec_file.c > +++ b/arch/s390/kernel/machine_kexec_file.c > @@ -329,7 +329,7 @@ int arch_kexec_apply_relocations_add(struct purgatory= _info *pi, > = > int arch_kimage_file_post_load_cleanup(struct kimage *image) > { > - kvfree(image->arch.ipl_buf); > + vfree(image->arch.ipl_buf); The problem reported above indicates that slab.h was not included. With your patch, while it fixes the problem for this particular configuration, this requires vmalloc.h to be included. I'll merge your patch and add the missing include as well. --===============4628767821686245455==--