Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D669C433EF for ; Wed, 15 Dec 2021 14:17:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id DC673C34607; Wed, 15 Dec 2021 14:17:10 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id CA03AC34605; Wed, 15 Dec 2021 14:17:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org CA03AC34605 Authentication-Results: smtp.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.kernel.org; spf=none smtp.mailfrom=linux.intel.com X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="300012018" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="300012018" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 06:17:08 -0800 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="567937520" Received: from smile.fi.intel.com ([10.237.72.184]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 06:16:57 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mxV4Z-006d5b-Tn; Wed, 15 Dec 2021 16:15:59 +0200 Date: Wed, 15 Dec 2021 16:15:59 +0200 From: Andy Shevchenko To: Geert Uytterhoeven List-Id: Cc: Linus Walleij , Marc Zyngier , Sam Shih , Zhiyong Tao , Ludovic Desroches , Claudiu Beznea , Radim Pavlik , Kavyasree Kotagiri , Colin Foster , Douglas Anderson , Bjorn Andersson , Dmitry Baryshkov , Herve Codina , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-actions@lists.infradead.org, Linux Kernel Mailing List , bcm-kernel-feedback-list , linux-rpi-kernel , - , ALSA Development Mailing List , linux-mediatek@lists.infradead.org, linux-oxnas@groups.io, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm , Linux-Renesas , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , Charles Keepax , Richard Fitzgerald , Sean Wang , Basavaraj Natikar , Shyam Sundar S K , Nicolas Ferre , Alexandre Belloni , Support Opensource , Baruch Siach , Neil Armstrong , Maxime Coquelin , Alexandre Torgue , Andy Gross , Geert Uytterhoeven , Viresh Kumar , Shiraz Hashim , arm-soc Subject: Re: [PATCH v1 1/2] pinctrl: Get rid of duplicate of_node assignment in the drivers Message-ID: References: <20211213163929.7509-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Dec 15, 2021 at 11:28:34AM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 13, 2021 at 5:40 PM Andy Shevchenko > wrote: > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove these assignment all at once. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > drivers/pinctrl/renesas/pinctrl-rza2.c | 1 - > > Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven Thanks, there is v2 with this patch w/o changes. I take a liberty to extrapolate the tags to it. I need to send a v3 in case Linus hasn't taken the first patch before it happens. -- With Best Regards, Andy Shevchenko