Content-Type: multipart/mixed; boundary="===============4644804078878942400==" MIME-Version: 1.0 From: Huang Rui To: kbuild-all@lists.01.org Subject: Re: [PATCH v3] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence Date: Thu, 16 Dec 2021 12:34:12 +0800 Message-ID: In-Reply-To: <202112152115.sqAqnvG7-lkp@intel.com> List-Id: --===============4644804078878942400== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Dec 15, 2021 at 09:30:31PM +0800, kernel test robot wrote: > Hi Huang, > = > I love your patch! Perhaps something to improve: > = > [auto build test WARNING on drm/drm-next] > [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip v5.1= 6-rc5 next-20211214] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit-s= cm.com%2Fdocs%2Fgit-format-patch&data=3D04%7C01%7Cray.huang%40amd.com%7= C57b8f278a2a14c8dab7908d9bfcf2649%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C= 0%7C637751718697946000%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi= V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3DGHmkohA1RYdTxSAsM= %2BGd1QhX%2BOREjXw0xuALuROXd7I%3D&reserved=3D0] > = > url: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F= %2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FHuang-Rui%2Fdrm-amdgpu-introduc= e-new-amdgpu_fence-object-to-indicate-the-job-embedded-fence%2F20211215-143= 731&data=3D04%7C01%7Cray.huang%40amd.com%7C57b8f278a2a14c8dab7908d9bfcf= 2649%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637751718697946000%7CUnkn= own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV= CI6Mn0%3D%7C3000&sdata=3DLqI6BC9bWIb9iq9BKIpIZ8R%2FYB2m4x3OkytvPxundbw%= 3D&reserved=3D0 > base: git://anongit.freedesktop.org/drm/drm drm-next > config: x86_64-allyesconfig (https://nam11.safelinks.protection.outlook.c= om/?url=3Dhttps%3A%2F%2Fdownload.01.org%2F0day-ci%2Farchive%2F20211215%2F20= 2112152115.sqAqnvG7-lkp%40intel.com%2Fconfig&data=3D04%7C01%7Cray.huang= %40amd.com%7C57b8f278a2a14c8dab7908d9bfcf2649%7C3dd8961fe4884e608e11a82d994= e183d%7C0%7C0%7C637751718697946000%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw= MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3D5fJoE= JtN2294YWevl8ys2VTHWh1AgaYtDOKuvg3Qi6w%3D&reserved=3D0) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=3D1 build): > # https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%= 2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommit%2Fa47becf231b123760625c45242e89f= 5e5b5b4915&data=3D04%7C01%7Cray.huang%40amd.com%7C57b8f278a2a14c8dab790= 8d9bfcf2649%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637751718697946000= %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW= wiLCJXVCI6Mn0%3D%7C3000&sdata=3DqbMYgGRhW%2BTUqKoJAodp5V2VNybzmekZLCinm= UtQhho%3D&reserved=3D0 > git remote add linux-review https://nam11.safelinks.protection.ou= tlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2F0day-ci%2Flinux&data=3D04%7= C01%7Cray.huang%40amd.com%7C57b8f278a2a14c8dab7908d9bfcf2649%7C3dd8961fe488= 4e608e11a82d994e183d%7C0%7C0%7C637751718697946000%7CUnknown%7CTWFpbGZsb3d8e= yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am= p;sdata=3DeX6JF%2FjinJTZj9CzP4tvTA3Chd8NODf85oNlSdCpq14%3D&reserved=3D0 > git fetch --no-tags linux-review Huang-Rui/drm-amdgpu-introduce-n= ew-amdgpu_fence-object-to-indicate-the-job-embedded-fence/20211215-143731 > git checkout a47becf231b123760625c45242e89f5e5b5b4915 > # save the config file to linux build tree > mkdir build_dir > make W=3D1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash drivers/= gpu/drm/amd/amdgpu/ > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All warnings (new ones prefixed by >>): > = > >> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:631: warning: expecting prot= otype for amdgpu_fence_clear_job_fences(). Prototype was for amdgpu_fence_d= river_clear_job_fences() instead > = Nice catch! Thank you. It's my typo and will fix this. Thanks, Ray > = > vim +631 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > = > 623 = > 624 /** > 625 * amdgpu_fence_clear_job_fences - clear job embedded fences of ri= ng > 626 * > 627 * @ring: fence of the ring to be cleared > 628 * > 629 */ > 630 void amdgpu_fence_driver_clear_job_fences(struct amdgpu_ring *ring) > > 631 { > 632 int i; > 633 struct dma_fence *old, **ptr; > 634 = > 635 for (i =3D 0; i <=3D ring->fence_drv.num_fences_mask; i++) { > 636 ptr =3D &ring->fence_drv.fences[i]; > 637 old =3D rcu_dereference_protected(*ptr, 1); > 638 if (old && old->ops =3D=3D &amdgpu_job_fence_ops) > 639 RCU_INIT_POINTER(*ptr, NULL); > 640 } > 641 } > 642 = > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists= .01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=3D04%7C01%= 7Cray.huang%40amd.com%7C57b8f278a2a14c8dab7908d9bfcf2649%7C3dd8961fe4884e60= 8e11a82d994e183d%7C0%7C0%7C637751718697946000%7CUnknown%7CTWFpbGZsb3d8eyJWI= joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sd= ata=3DKIv5jCARD1lYITkfLGINkMIF93OGw2MAf6yAAs64KXU%3D&reserved=3D0 --===============4644804078878942400==--