From: Peter Zijlstra Subject: Re: [PATCH 1/2] cgroup: add cpu.stat_percpu Date: Wed, 12 Jan 2022 09:30:23 +0100 Message-ID: References: <20220107234138.1765668-1-joshdon@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=13bfDwC4Q9dgAZpU/RAeEl2vEaor8KDQuawgF7gUxzo=; b=u4J/qAfmQnxgC0O1RunRdY0Voc hgGawk8rMe8I6Z8rdGysGN3Ulzh2Culzl7aB2cSzmp3/sc4Szea2bwv14BiDsqBPtUPHgaGV1JlLY L44pdHm06jhzUq14uktN/t+5PHqUiUisq0PNllMY2ZQz7k4Ku+FzQvkxQOzrA6TzYsW05NZMXn+24 DzRlKhW0CkAU8vAU3QzWP7s+bwzXP57mG/KATB+CmnKNUP/CkdKJJuBejUX/9GINss86dy0PmKrtO 87gu3XffXlZBy4jPwBjm0QGNQBuAoKj0Z6xVLFzqyw959q5XaCYiehWYitGzI7ig0WbFVQojsAyP2 N1IAEzjQ==; Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Josh Don Cc: Tejun Heo , Zefan Li , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , cgroups@vger.kernel.org, linux-kernel On Tue, Jan 11, 2022 at 03:38:20PM -0800, Josh Don wrote: > On Tue, Jan 11, 2022 at 4:50 AM Peter Zijlstra wrote: > > > > On Fri, Jan 07, 2022 at 03:41:37PM -0800, Josh Don wrote: > > > > > + seq_puts(seq, "usage_usec"); > > > + for_each_possible_cpu(cpu) { > > > + cached_bstat = per_cpu_ptr(&cached_percpu_stats, cpu); > > > + val = cached_bstat->cputime.sum_exec_runtime; > > > + do_div(val, NSEC_PER_USEC); > > > + seq_printf(seq, " %llu", val); > > > + } > > > + seq_puts(seq, "\n"); > > > + > > > + seq_puts(seq, "user_usec"); > > > + for_each_possible_cpu(cpu) { > > > + cached_bstat = per_cpu_ptr(&cached_percpu_stats, cpu); > > > + val = cached_bstat->cputime.utime; > > > + do_div(val, NSEC_PER_USEC); > > > + seq_printf(seq, " %llu", val); > > > + } > > > + seq_puts(seq, "\n"); > > > + > > > + seq_puts(seq, "system_usec"); > > > + for_each_possible_cpu(cpu) { > > > + cached_bstat = per_cpu_ptr(&cached_percpu_stats, cpu); > > > + val = cached_bstat->cputime.stime; > > > + do_div(val, NSEC_PER_USEC); > > > + seq_printf(seq, " %llu", val); > > > + } > > > + seq_puts(seq, "\n"); > > > > This is an anti-pattern; given enough CPUs (easy) this will trivially > > overflow the 1 page seq buffer. > > > > People are already struggling to fix existing ABI, lets not make the > > problem worse. > > Is the concern there just the extra overhead from making multiple > trips into this handler and re-allocating the buffer until it is large > enough to take all the output? In that case, we could pre-allocate > with a size of the right order of magnitude, similar to /proc/stat. > > Lack of per-cpu stats is a gap between cgroup v1 and v2, for which v2 > can easily support this interface given that it already tracks the > stats percpu internally. I opted to dump them all in a single file > here, to match the consolidation that occurred from cpuacct->cpu.stat. Hmm.. fancy new stuff there :-) Yes, I think that would aleviate the immediate problem. I suppose /proc/interrupts ought to get some of that too. Still, I'm not sure having so much data in a single file is wise. But I've not really kept up with the discussions around this problem much.