Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0104DC433EF for ; Wed, 12 Jan 2022 19:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UepKyJs48SNDwpnL1fq4QbPIenQgcEXQZ21GKVcT3wI=; b=VUbpv8XvoDJaN6 PnrMg5kep4Dg1CgVPSWDMQ2U8XqTazn54ZwSUIJUOwhCMAOTYdom1t8E6GtrZXZGHvV9bviHxyyCi UJDMka26xDAsjZNGGCfc1FLb2mqDW25axy5EnjfYQn/+WS+ISopO86D5+G2uJlC2AoZw5+1dU/XRJ qAhkl95f80N+0+urZOe2O1UHPtf+7l3Yktbw72VULInsU4VWooKWy3W+Z57n6mDaXOJMGw94/9OTx B8G++VJ0Oev/ODc+zv76oDGr/0Wyc/6ZJgbktkbK9DyAlMaYLMb/lJA6VVwaG5jXcOhC6vX6bmb5w OYHOz2KuNsJEPcQXsP+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7jYS-003dVF-KI; Wed, 12 Jan 2022 19:45:08 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7jYP-003dUo-Ju for linux-arm-kernel@lists.infradead.org; Wed, 12 Jan 2022 19:45:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=+PIw2F9Pxe9m/og1B2EVUD67ui08c2oSdDdwW2s8nEk=; b=r20G8jm19XPvotYa9kp2u67Txn 4VIDZ/Q3ZzpvcGImKcxwS3jWGsKZQ5phG66lMS57QXgFp2dg8nZeUWaobUG2EAqjd5x8NmQ2wSQJD alCJd6cbphiGaJ1nN/ytHbaxoE2IY3D+hUjmyrmBwW5lrIWA9v+FuqcrNsUFiLqEjsEw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n7jYI-001EGf-QF; Wed, 12 Jan 2022 20:44:58 +0100 Date: Wed, 12 Jan 2022 20:44:58 +0100 From: Andrew Lunn To: Robert Hancock Cc: "daniel@iogearbox.net" , "radhey.shyam.pandey@xilinx.com" , "michal.simek@xilinx.com" , "kuba@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "ariane.keller@tik.ee.ethz.ch" Subject: Re: [PATCH net v2 2/9] net: axienet: Wait for PhyRstCmplt after core reset Message-ID: References: <20220112173700.873002-1-robert.hancock@calian.com> <20220112173700.873002-3-robert.hancock@calian.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_114505_686488_DD737713 X-CRM114-Status: GOOD ( 11.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > Is this bit guaranteed to be clear before you start waiting for it? > > The documentation for the IP core ( > https://www.xilinx.com/content/dam/xilinx/support/documentation/ip_documentation/axi_ethernet/v7_2/pg138-axi-ethernet.pdf > ) states for the phy_rst_n output signal: "This active-Low reset is held > active for 10 ms after power is applied and during any reset. After the reset > goes inactive, the PHY cannot be accessed for an additional 5 ms." The > PhyRstComplt bit definition mentions "This signal does not transition to 1 for > 5 ms after PHY_RST_N transitions to 1". Given that a reset of the core has just > been completed above, the PHY reset should at least have been initiated as > well, so it should be sufficient to just wait for the bit to become 1 at this > point. Great, thanks for checking. Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel