Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44B76C433EF for ; Sat, 1 Jan 2022 22:02:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D0DE10E1D1; Sat, 1 Jan 2022 22:02:54 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86A0210E1D1 for ; Sat, 1 Jan 2022 22:02:52 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D2EFEE; Sat, 1 Jan 2022 23:02:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1641074570; bh=DXY+IfPxOjgFMcnlWMqtzH4AWyqCUY/AFI8EsQNPXno=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UhTtEPj3mM/xcMWDqH32oQxqTrfOowsYqIat2HVJH4owiRvtSaMOr+8eiHtcixnER PN1BfwUMVCR5hwYYwkTQgDhb4pCxMmwCMUDofoRFF0c6VTkBCPBVW2yXpYMAhT0qb8 WpHO63u1pHlyQx4M+03oUStTrgAvSe9rnBCpNqJs= Date: Sun, 2 Jan 2022 00:02:48 +0200 From: Laurent Pinchart To: Marek Vasut Subject: Re: [PATCH] drm: mxsfb: Shutdown the display on system shutdown Message-ID: References: <20220101213755.506404-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220101213755.506404-1-marex@denx.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Marek, Thank you for the patch. On Sat, Jan 01, 2022 at 10:37:55PM +0100, Marek Vasut wrote: > When the system shuts down or warm reboots, the display may be active. > Implement the platform_driver .shutdown() operation and shut down the > display. > > Signed-off-by: Marek Vasut > Cc: Daniel Vetter > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Sam Ravnborg > Cc: Stefan Agner > Cc: Thomas Zimmermann Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index 6d7a3aeff50b0..375f26d4a4172 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -381,6 +381,13 @@ static int mxsfb_remove(struct platform_device *pdev) > return 0; > } > > +static void mxsfb_shutdown(struct platform_device *pdev) > +{ > + struct drm_device *drm = platform_get_drvdata(pdev); > + > + drm_atomic_helper_shutdown(drm); > +} > + > #ifdef CONFIG_PM_SLEEP > static int mxsfb_suspend(struct device *dev) > { > @@ -404,6 +411,7 @@ static const struct dev_pm_ops mxsfb_pm_ops = { > static struct platform_driver mxsfb_platform_driver = { > .probe = mxsfb_probe, > .remove = mxsfb_remove, > + .shutdown = mxsfb_shutdown, > .driver = { > .name = "mxsfb", > .of_match_table = mxsfb_dt_ids, -- Regards, Laurent Pinchart