Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64B73C433F5 for ; Sat, 8 Jan 2022 15:17:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C6CFC8303C; Sat, 8 Jan 2022 16:17:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 7C97683736; Sat, 8 Jan 2022 16:16:58 +0100 (CET) Received: from ams.blueri.se (ams.blueri.se [IPv6:2a03:6000:6f70:601::204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E9E568303C for ; Sat, 8 Jan 2022 16:16:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrick@blueri.se Received: from ryzen.fritz.box (p5b211402.dip0.t-ipconnect.de [91.33.20.2]) by ams.blueri.se (OpenSMTPD) with ESMTPSA id d6b7a19c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 8 Jan 2022 16:16:55 +0100 (CET) Date: Sat, 8 Jan 2022 16:16:53 +0100 From: Patrick Wildt To: Fabio Estevam Cc: Frieder Schrempf , Heiko Schocher , Marcel Ziswiler , Heiko Thiery , Peng Fan , Tom Rini , Stefano Babic , u-boot@lists.denx.de Subject: Re: [PATCH] imx8mq: Generate a single bootable flash.bin again Message-ID: References: <570a5a2745573642f349cdbd1d501d19@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <570a5a2745573642f349cdbd1d501d19@denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, Jan 08, 2022 at 12:10:49PM -0300, Fabio Estevam wrote: > On 08/01/2022 11:58, Patrick Wildt wrote: > > After the conversion to binman in commit c1ecd03d90c7 ("imx: imx8mq_evk: > > switch to binman"), it is necessary to flash both flash.bin and > > u-boot.itb to get a bootable system. Prior to this commit, only > > flash.bin was needed. > > > > Such new requirement breaks existing distro mechanisms to generate the > > final binary because the extra u-boot.itb is now required. > > > > Generate a final flash.bin that can be used again as a single bootable > > binary to keep the original behavior. > > > > After this change the SPL binary is called spl.bin, which is a more > > descriptive name for its purpose, and can still be used standalone (for > > example, for secure boot purposes). > > > > Also update imx8mq_evk.rst to remove the u-boot.itb copy step. > > > > This is a cherry-pick of 028abfd9b157 ("imx8mm-evk: Generate a single > > bootable flash.bin again") adjusted to apply to i.MX8MQ. > > "apply to imx8mq_evk." > > Also, the subject should be imx8mq_evk: Generate... > > Feel free to resubmit with these two minor changes and keep my Reviewed-by > tag. > > Thanks, > > Fabio Estevam Hi, but it's not only imx8mq_evk. Tom has merged the patchset that switches *all* i.MX8MQ boards to Binman, which means that this change touches not only imx8mq_evk but all i.MX8MQ boards. The only thing that is specific to imx8mq_evk is the documentation change. Should I still change it? Thanks, Patrick