Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B09D9C433FE for ; Tue, 25 Jan 2022 08:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1449605AbiAYISv (ORCPT ); Tue, 25 Jan 2022 03:18:51 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:41198 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1448806AbiAYIQV (ORCPT ); Tue, 25 Jan 2022 03:16:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5357861354; Tue, 25 Jan 2022 08:16:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12BD0C340E0; Tue, 25 Jan 2022 08:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643098580; bh=j0tZzZOrnwVB4wbKHRy+RU8Y6rBsvR3ZlnbOYKPxPT8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nsRcNYp9fpObActyzs4p3qGTzjmVp+6XUM669JRpuHe+73xvWTfSK+EH3uvxQ6841 W+vh8em+1Ta4sQf6mMyt+c0VA6FVhrhff8mIQJppO+R6ObBh0SYseuwhCTvmHZK1iR RE9XtEfnqNSgDO7Vp84Q3/C8gojx6/VfyFq8F8Is= Date: Tue, 25 Jan 2022 09:16:17 +0100 From: Greg Kroah-Hartman To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Felix Kuehling , David Yat Sin , Rajneesh Bhardwaj , Alex Deucher , Sasha Levin Subject: Re: [PATCH 5.16 0702/1039] drm/amdgpu: Dont inherit GEM object VMAs in child process Message-ID: References: <20220124184125.121143506@linuxfoundation.org> <20220124184148.931014095@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Jan 25, 2022 at 08:26:20AM +0100, Christian König wrote: > Hi Greg, > > Am 24.01.22 um 19:41 schrieb Greg Kroah-Hartman: > > From: Rajneesh Bhardwaj > > > > [ Upstream commit fbcdbfde87509d523132b59f661a355c731139d0 ] > > > > When an application having open file access to a node forks, its shared > > mappings also get reflected in the address space of child process even > > though it cannot access them with the object permissions applied. With the > > existing permission checks on the gem objects, it might be reasonable to > > also create the VMAs with VM_DONTCOPY flag so a user space application > > doesn't need to explicitly call the madvise(addr, len, MADV_DONTFORK) > > system call to prevent the pages in the mapped range to appear in the > > address space of the child process. It also prevents the memory leaks > > due to additional reference counts on the mapped BOs in the child > > process that prevented freeing the memory in the parent for which we had > > worked around earlier in the user space inside the thunk library. > > > > Additionally, we faced this issue when using CRIU to checkpoint restore > > an application that had such inherited mappings in the child which > > confuse CRIU when it mmaps on restore. Having this flag set for the > > render node VMAs helps. VMAs mapped via KFD already take care of this so > > this is needed only for the render nodes. > > > > To limit the impact of the change to user space consumers such as OpenGL > > etc, limit it to KFD BOs only. > > > > Acked-by: Felix Kuehling > > Reviewed-by: Christian König > > Signed-off-by: David Yat Sin > > Signed-off-by: Rajneesh Bhardwaj > > Signed-off-by: Alex Deucher > > Signed-off-by: Sasha Levin > > Please drop this patch from all stable versions since it was reverted from > upstream later on. The revert comes later in the patch series, so all should be ok :) thanks, greg k-h