Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2598C433EF for ; Thu, 13 Jan 2022 13:16:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E14AC832E3; Thu, 13 Jan 2022 14:16:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 82A4583373; Thu, 13 Jan 2022 14:16:46 +0100 (CET) Received: from ams.blueri.se (ams.blueri.se [IPv6:2a03:6000:6f70:601::204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 34331832DA for ; Thu, 13 Jan 2022 14:16:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrick@blueri.se Received: from ryzen.fritz.box (p5b0ac7de.dip0.t-ipconnect.de [91.10.199.222]) by ams.blueri.se (OpenSMTPD) with ESMTPSA id fb833044 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 13 Jan 2022 14:16:43 +0100 (CET) Date: Thu, 13 Jan 2022 14:16:41 +0100 From: Patrick Wildt To: Michael Walle Cc: festevam@denx.de, frieder.schrempf@kontron.de, heiko.thiery@gmail.com, hs@denx.de, marcel.ziswiler@toradex.com, peng.fan@oss.nxp.com, sbabic@denx.de, trini@konsulko.com, u-boot@lists.denx.de Subject: Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name Message-ID: References: <20220113114250.2656319-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220113114250.2656319-1-michael@walle.cc> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Jan 13, 2022 at 12:42:50PM +0100, Michael Walle wrote: > Hi, > > > --- a/arch/arm/dts/imx8mm-u-boot.dtsi > > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi > > @@ -39,7 +39,7 @@ > > filename = "u-boot-spl.bin"; > > }; > > > > - 1d-imem { > > + 1d_imem { > > I think it is the other way around. Device tree node names should contain > hyphens and not underscores. > > I couldn't find any references in dtschema though. Maybe I haven't looked > hard enough. > > But you can see linux commit 28d7f0f3f10b, for example. > > -michael Hi, I don't know what's right, but every other of these in the i.MX8MM file use _ instead of -, so if at all this makes it consistenly wrong, but at least now it's consistent. ;) If it's wrong, I'm sure someone will step up and rectify it. Cheers, Patrick