Content-Type: multipart/mixed; boundary="===============6361336348680973263==" MIME-Version: 1.0 From: Mark Brown To: kbuild-all@lists.01.org Subject: Re: [PATCH v2] sound/soc: adds TAS5754M digital input amplifier component driver Date: Wed, 26 Jan 2022 16:44:24 +0000 Message-ID: In-Reply-To: <20220119125033.GA2144@ubuntu> List-Id: --===============6361336348680973263== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Jan 19, 2022 at 01:50:33PM +0100, Joerg Schambacher wrote: > Thanks for your useful feedback. I guess my comments on my first reply go= t lost somewhere on the way .... Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > On Wed, Nov 17, 2021 at 03:13:47PM +0000, Mark Brown wrote: > > On Fri, Oct 29, 2021 at 11:57:30AM +0200, Joerg Schambacher wrote: > > > + mclk =3D clk_get_rate(tas5754m->sclk); > > > + bclk =3D sample_len * 2 * params_rate(params); > > snd_soc_params_to_bclk(). > snd_soc_params_to_bclk() does not always gives the necessary value In what way does it not give the needed value, and is that perhaps a symptom of the constraints not being accurate? > > > + if (mute) { > > > + snd_soc_component_write(component, TAS5754M_MUTE, 0x11); > > > + } else { > > > + usleep_range(1000, 2000); > > > + snd_soc_component_write(component, TAS5754M_MUTE, 0x00); > > Why the sleep here? > Wait for settling of the clocks before unmute Why would you need to wait for the clocks (which clocks?) to settle before the unmute, this sounds like something that needs to be addressed in whatever is providing the clocks. > > If the register map can be copied can't the two drivers be combined? > The TI apps team recommended to write a separate driver as there are some= differences. I have also aligned some names to the TAS575xM spec in the ne= xt patch What concrete differences are there here? "The TI apps team said so" isn't really upstream discussion or review... > > > +#define TAS5754M_VIRT_BASE 0x000 > > > +#define TAS5754M_PAGE_LEN 0x80 > > > +#define TAS5754M_PAGE_BASE(n) (TAS5754M_VIRT_BASE + (TAS5754M_PAGE_= LEN * n)) > > > +#define TAS5754M_PAGE 0 > > There's no mention of paging in the regmap description for the driver > > which feels like it's asking for problems. > I think, it's defined in the correct way. Where/when exactly do you see a= problem? If there is paging going on and the regmap code doesn't know about it then that makes it seem likely that the regmap code is going to get confused about what's going on with the device. What makes you say that "it's defined in the correct way" if there's no mention of paging in the regmap config? --===============6361336348680973263== Content-Type: application/pgp-signature MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRRXpCQUFCQ2dBZEZpRUVyZVpvcW1kWEdM V2Y0cC9xSk5hTGNsMVVoOUFGQW1IeGVtY0FDZ2tRSk5hTGNsMVUKaDlDM2tBZjhDNFVidVV3ZEly R3FzV2JKOUw1cW5PQVZJQ2tIaUgwejV5VndLVU80dFVOTllTdkY4L3Q0ZEJvRQpaRG9vaXZFZXph NXE5eWltbFNDL0dBbTV3Qm5Cc3k1VjU5RElLdkl1N0Y3Rlc0RDJUMzB4N3h6cTJwS3EwazFFClZm eHBlZUsyWm9NMXlqb1lObUIyUE5SZlpxNGExN1FlZDY5MC9LVXFIUHdjU2dZU1FqemFDcW5NWFpn LzRaTncKUnBHemNPdEpNdWFsWjJTYjdRU1hkSVBnMFd1bWo2NU4zK09uNWRubzhDQi9UYjdLb3Fy THlSTXFEaW1LSmJuaQpzQzU3NDRMTit3YVoyTlZxM0tuekNJVm5BTllTd1ZQOEIrNWthNncxc0FU THNoYS9UQ2laa3lQdjhSaVFocERSCkRCK3ZpeG04eUdaNlNDZjlPZ24rTGdXSGtBQ2NxUT09Cj1K ZTZqCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============6361336348680973263==--