From: Roman Gushchin Subject: Re: [PATCH v2 3/3] mm/page_owner: Dump memcg information Date: Wed, 2 Feb 2022 07:54:48 -0800 Message-ID: References: <20220129205315.478628-1-longman@redhat.com> <20220129205315.478628-4-longman@redhat.com> <12686956-612d-d89b-5641-470d5e913090@redhat.com> <268a8bdf-4c70-b967-f34c-2293b54186f0@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=facebook; bh=PntVkuMfTienoR7WfCrdOCIGWX4pTWY+Pz9DpDetKJ8=; b=VNORFQ5cMkGak4CBsI4tJMn4n3sMeUXdGyjd3r/Fju07zsvC3A9PN7yicCXrCUMt8bqM KAShRCFV65f0gGH2CG4R6o2Fr5zeNvUrOUfMj8/sv4OPNaxdHtZTSfqpVYB0TNOEVfUm sIFpjZa1K15G7SLbHOsDhrla2cMKQ/8McMY= Content-Disposition: inline In-Reply-To: List-ID: Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: Waiman Long , Johannes Weiner , Vladimir Davydov , Andrew Morton , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Ira Weiny , Rafael Aquini On Wed, Feb 02, 2022 at 09:57:18AM +0100, Michal Hocko wrote: > On Tue 01-02-22 11:41:19, Waiman Long wrote: > > > > On 2/1/22 05:49, Michal Hocko wrote: > [...] > > > Could you be more specific? Offlined memcgs are still part of the > > > hierarchy IIRC. So it shouldn't be much more than iterating the whole > > > cgroup tree and collect interesting data about dead cgroups. > > > > What I mean is that without piggybacking on top of page_owner, we will to > > add a lot more code to collect and display those information which may have > > some overhead of its own. > > Yes, there is nothing like a free lunch. Page owner is certainly a tool > that can be used. My main concern is that this tool doesn't really > scale on large machines with a lots of memory. It will provide a very > detailed information but I am not sure this is particularly helpful to > most admins (why should people process tons of allocation backtraces in > the first place). Wouldn't it be sufficient to have per dead memcg stats > to see where the memory sits? > > Accumulated offline memcgs is something that bothers more people and I > am really wondering whether we can do more for those people to evaluate > the current state. Cgroup v2 has corresponding counters for years. Or do you mean something different?