Content-Type: multipart/mixed; boundary="===============2486928684711859935==" MIME-Version: 1.0 From: Sean Christopherson To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 3/7] KVM: nVMX: Roll all entry/exit ctl updates into a single helper Date: Mon, 07 Feb 2022 17:56:38 +0000 Message-ID: In-Reply-To: List-Id: --===============2486928684711859935== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Sat, Feb 05, 2022, Oliver Upton wrote: > On Fri, Feb 4, 2022 at 11:44 PM kernel test robot wrote: > > >> ERROR: modpost: "kvm_pmu_is_valid_msr" [arch/x86/kvm/kvm-intel.ko] u= ndefined! > = > Argh... Local tooling defaults to building KVM nonmodular so I missed thi= s. > = > Squashing the following in fixes the issue. > = > -- > diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c > index f614f95acc6b..18430547357d 100644 > --- a/arch/x86/kvm/pmu.c > +++ b/arch/x86/kvm/pmu.c > @@ -396,6 +396,7 @@ bool kvm_pmu_is_valid_msr(struct kvm_vcpu *vcpu, u32 = msr) > return kvm_x86_ops.pmu_ops->msr_idx_to_pmc(vcpu, msr) || > kvm_x86_ops.pmu_ops->is_valid_msr(vcpu, msr); > } > +EXPORT_SYMBOL_GPL(kvm_pmu_is_valid_msr); I'd much prefer to avoid this mess entirely. [*] https://lore.kernel.org/all/20220128005208.4008533-9-seanjc(a)google.com --===============2486928684711859935==--