Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFB6C433EF for ; Sat, 12 Feb 2022 15:35:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235385AbiBLPfI (ORCPT ); Sat, 12 Feb 2022 10:35:08 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbiBLPfI (ORCPT ); Sat, 12 Feb 2022 10:35:08 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E074D83 for ; Sat, 12 Feb 2022 07:35:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 061EFB80763 for ; Sat, 12 Feb 2022 15:35:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5857BC340E7; Sat, 12 Feb 2022 15:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644680101; bh=B9Sw/I/OpYGvbzD8UTV9BDbAOP1KkfXv4veEROWp/vM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tZ9nYgjrXtLHkChiafrhi1M1reHeDpJIAu7yboPzpgkjupwX8MWn3jEVkEKagJh8v dqV5ZT4i8JLXddrahdOSLvmyJIKJWtPtrkVrhjbTELU1qcW0lG842AyFFAoa0oHXFW ma/y8qMBpoCYo2v4oaVvuU4TmnGD+CC27uUVEiJeoY4aV6+DSnigArqtVmQcTS7bON Qazzj0NmixEoFtEAs/IVq2TMQHOAEZCeCesUmBp0ROeDwk6ux5DfCD1eGl9hCUUV8Z zTsRNvGjB/CKNuyI6CIWQQ1dBT6G7+hmLO+3nJAUpJQE9nDMTvWukfuveTBUTyUI4F fOELV7dYlD9MQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 691A9400FE; Sat, 12 Feb 2022 12:34:58 -0300 (-03) Date: Sat, 12 Feb 2022 12:34:58 -0300 From: Arnaldo Carvalho de Melo To: Andrii Nakryiko Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com Subject: Re: [PATCH v5 bpf-next 0/2] perf: stop using deprecated bpf APIs Message-ID: References: <20220212073054.1052880-1-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220212073054.1052880-1-andrii@kernel.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Em Fri, Feb 11, 2022 at 11:30:52PM -0800, Andrii Nakryiko escreveu: > libbpf's bpf_prog_load() and bpf__object_next() APIs are deprecated. > remove perf's usage of these deprecated functions. After this patch > set, the only remaining libbpf deprecated APIs in perf would be > bpf_program__set_prep() and bpf_program__nth_fd(). Not applying to perf/core, I'm checking... ⬢[acme@toolbox perf]$ b4 am -ctsl --cc-trailers 20220212073054.1052880-1-andrii@kernel.org Looking up https://lore.kernel.org/r/20220212073054.1052880-1-andrii%40kernel.org Grabbing thread from lore.kernel.org/all/20220212073054.1052880-1-andrii%40kernel.org/t.mbox.gz Checking for newer revisions on https://lore.kernel.org/all/ Analyzing 3 messages in the thread Checking attestation on all messages, may take a moment... --- [PATCH v5 1/2] perf: Stop using deprecated bpf_load_program() API + Signed-off-by: Arnaldo Carvalho de Melo + Link: https://lore.kernel.org/r/20220212073054.1052880-2-andrii@kernel.org + Cc: kernel-team@fb.com + Cc: daniel@iogearbox.net + Cc: ast@kernel.org + Cc: bpf@vger.kernel.org [PATCH v5 2/2] perf: Stop using deprecated bpf_object__next() API + Signed-off-by: Arnaldo Carvalho de Melo + Link: https://lore.kernel.org/r/20220212073054.1052880-3-andrii@kernel.org + Cc: kernel-team@fb.com + Cc: daniel@iogearbox.net + Cc: ast@kernel.org + Cc: bpf@vger.kernel.org --- Total patches: 2 --- Cover: ./v5_20220211_andrii_perf_stop_using_deprecated_bpf_apis.cover Link: https://lore.kernel.org/r/20220212073054.1052880-1-andrii@kernel.org Base: not specified git am ./v5_20220211_andrii_perf_stop_using_deprecated_bpf_apis.mbx ⬢[acme@toolbox perf]$ git am ./v5_20220211_andrii_perf_stop_using_deprecated_bpf_apis.mbx Applying: perf: Stop using deprecated bpf_load_program() API Applying: perf: Stop using deprecated bpf_object__next() API error: patch failed: tools/perf/util/bpf-loader.c:68 error: tools/perf/util/bpf-loader.c: patch does not apply Patch failed at 0002 perf: Stop using deprecated bpf_object__next() API hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". - Arnaldo > v4 -> v5: > - add bpf_perf_object__add() and use it where appropriate (Jiri); > - use __maybe_unused in first patch; > v3 -> v4: > - Fixed commit title > - Added weak definition for deprecated function > v2 -> v3: > - Fixed commit message to use upstream perf > v1 -> v2: > - Added missing commit message > - Added more details to commit message and added steps to reproduce > original test case. > > Christy Lee (2): > perf: Stop using deprecated bpf_load_program() API > perf: Stop using deprecated bpf_object__next() API > > tools/perf/tests/bpf.c | 14 ++---- > tools/perf/util/bpf-event.c | 13 +++++ > tools/perf/util/bpf-loader.c | 98 +++++++++++++++++++++++++++++------- > 3 files changed, 96 insertions(+), 29 deletions(-) > > -- > 2.30.2 -- - Arnaldo