Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA85C433F5 for ; Mon, 28 Feb 2022 15:11:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F7AC8D0002; Mon, 28 Feb 2022 10:11:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A4368D0001; Mon, 28 Feb 2022 10:11:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 793E58D0002; Mon, 28 Feb 2022 10:11:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 67CAD8D0001 for ; Mon, 28 Feb 2022 10:11:30 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1420E95278 for ; Mon, 28 Feb 2022 15:11:30 +0000 (UTC) X-FDA: 79192527540.23.03CFF64 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf22.hostedemail.com (Postfix) with ESMTP id 735DDC0019 for ; Mon, 28 Feb 2022 15:11:29 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1F643219A2; Mon, 28 Feb 2022 15:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1646061088; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nx7T66rlXmn1/P94LhUa9N7gYHbptxzfbjxOTP+KV4s=; b=VfQxld1BmxyYbbrWlbYbmtaO5z/+1FK2e0PIL7TViQVtn9j2aPqGuUHJzQVi3LMKcK0Hmp /AtM8OzRx6P2s13LsmgOvEJkw/ihsfEJwxUF2LET2eAYaw/K5UpBbHkHpKHRPkAPxK4EKs fWsQFV4WPDY2Sn1WquqZUs+8klUariM= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id DF3FDA3B83; Mon, 28 Feb 2022 15:11:27 +0000 (UTC) Date: Mon, 28 Feb 2022 16:11:24 +0100 From: Michal Hocko To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/oom_kill: remove unneeded is_memcg_oom check Message-ID: References: <20220224115933.20154-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224115933.20154-1-linmiaohe@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 735DDC0019 X-Stat-Signature: brsupuknimrnq5bxh6d5h85ectiiwk4y Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=VfQxld1B; spf=pass (imf22.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1646061089-11610 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 24-02-22 19:59:33, Miaohe Lin wrote: > oom_cpuset_eligible is always called when !is_memcg_oom. Remove this > unnecessary check. > > Signed-off-by: Miaohe Lin Acked-by: Michal Hocko Thanks! > --- > mm/oom_kill.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 9fea6d3c1ec7..c70a4330e548 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -122,9 +122,6 @@ static bool oom_cpuset_eligible(struct task_struct *start, > bool ret = false; > const nodemask_t *mask = oc->nodemask; > > - if (is_memcg_oom(oc)) > - return true; > - > rcu_read_lock(); > for_each_thread(start, tsk) { > if (mask) { > -- > 2.23.0 -- Michal Hocko SUSE Labs