Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BDE6C433EF for ; Thu, 3 Mar 2022 09:22:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231937AbiCCJWp (ORCPT ); Thu, 3 Mar 2022 04:22:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231898AbiCCJWi (ORCPT ); Thu, 3 Mar 2022 04:22:38 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81E7F16BCD6 for ; Thu, 3 Mar 2022 01:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wSfdxgMpexvaGq5XM+GJJwov6imXd8ZNqL+4cMK4gH4=; b=WORL/jVuE4m+eQQjEWaLim2oiq +SqFjnrVRRX9M+YqfASgcFm0LHV3Y43/z2Wa+rumbYEEHTvNL3GO77wTX+RI5FZmU7LAJ/dzf/LUx POiME4aXd/GE+XLqk4r2AmHeYHIzsg90DrtcPiDg6Rmz6cWjq98MrA+pVrH/76ck7RxNAfygy+DEw vBiTp6upchf8BQy3dGqeAN55BePtKZWSyo1osrCVokUH3CiFcY0UwbLllrnxo/B7TM8uJ9aBJ+NI2 IT1HO0dTinm6N4JiqqRvBMu3I5s1b7KaE3raWxrpvXM81Dhh4ywmq5nePGYdd9ABK7MUE1kIrgyZJ uyIFcmNQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57604) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nPheX-0003Gm-6m; Thu, 03 Mar 2022 09:21:41 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nPheU-0000ax-3n; Thu, 03 Mar 2022 09:21:38 +0000 Date: Thu, 3 Mar 2022 09:21:38 +0000 From: "Russell King (Oracle)" To: Landen Chao , DENG Qingfang , Sean Wang Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC net-next v2 0/7] net: dsa: mt7530: updates for phylink changes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 23, 2022 at 11:33:56AM +0000, Russell King (Oracle) wrote: > Hi, > > This revised series is a partial conversion of the mt7530 DSA driver to > the modern phylink infrastructure. This driver has some exceptional > cases which prevent - at the moment - its full conversion (particularly > with the Autoneg bit) to using phylink_generic_validate(). > > Patch 1 fixes the incorrect test highlighted in the first RFC series. > > Patch 2 fixes the incorrect assumption that RGMII is unable to support > 1000BASE-X. > > Patch 3 populates the supported_interfaces for each port > > Patch 4 removes the interface checks that become unnecessary as a result > of patch 3. > > Patch 5 removes use of phylink_helper_basex_speed() which is no longer > required by phylink. > > Patch 6 becomes possible after patch 5, only indicating the ethtool > modes that can be supported with a particular interface mode - this > involves removing some modes and adding others as per phylink > documentation. > > Patch 7 switches the driver to use phylink_get_linkmodes(), which moves > the driver as close as we can to phylink_generic_validate() due to the > Autoneg bit issue mentioned above. > > Patch 8 converts the driver to the phylink pcs support, removing a bunch > of driver private indirected methods. We include TRGMII as a PCS even > though strictly TRGMII does not have a PCS. This is convenient to allow > the change in patch 9 to be made. > > Patch 9 moves the special autoneg handling to the PCS validate method, > which means we can convert the MAC side to the generic validator. > > Patch 10 marks the driver as non-legacy. > > Please review and test, thanks. > > drivers/net/dsa/mt7530.c | 330 +++++++++++++++++++++-------------------------- > drivers/net/dsa/mt7530.h | 26 ++-- > 2 files changed, 159 insertions(+), 197 deletions(-) Ping? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!