Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC7DC433EF for ; Fri, 25 Mar 2022 08:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355891AbiCYIxH (ORCPT ); Fri, 25 Mar 2022 04:53:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354281AbiCYIxG (ORCPT ); Fri, 25 Mar 2022 04:53:06 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 066AC53A4A for ; Fri, 25 Mar 2022 01:51:33 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id i12so4782862ilu.5 for ; Fri, 25 Mar 2022 01:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=D+ewmka4Gd8DAMHHQuozzPeOxQhpVTwVoGFD7qhHhPs=; b=EmuKVvi9M1eAh5stXUDrlPwv/SJMwHUAT4uY3DOSKr64k1SA6eCCsIlkfzTtnoVz66 8K4uQ7h9YSh/R1wi4ogUkG8ayYlPpsEw6HiQJa14cdkhqgKs2pVKws38OtMQtaKosELk CUayzinuHGmMDVy+fWPRQ1UdSAbHh7P2xrISjl3ENUOdwyzF5aoyYPjwZgvg/cQLY9WZ yKCtIaE0VPFxEC0z1RRpOS6aFi7IKqT8XfAY/RSRsE10nM2yJbxwXcK6UVnMJcknO7sC sMgfLZNzvmo8qCDK2/Z5HyjtFEKSFyyCjXk+oinCRW8TtbDfaT8gpmrAj5WFgGz8cTg8 gt7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D+ewmka4Gd8DAMHHQuozzPeOxQhpVTwVoGFD7qhHhPs=; b=DC763jap3DJBWiRZJsramnZjeTjtpQ4Wm7x2KR+b6/v+K7jWcMde3uXjy69bWGxXlw w5aSke1HDy4cLuL+uds7NQvijQhCshPSxe6RIb1FWmaOcNB2ZdMbA6kbnec8jLbiJfJn PRIam6xeOw6KU6nlC2Gu19wpAVSGYLvbWhVbEEJFfdk3dKIFGmjWOgeEkH5o7ZJo1NCd NVeBx0BP8+YcyptXBNIMmRJAL75bJk3ZNnMYr2rKqDxka5EgU65XfTjc1vlpbG84Vcer L78hIN3j8tGBfURyW3W99g8+q7VHcD+54Zauq5IpqSdtj6zlTPg9VjVBZON8TqUj717o 2CRw== X-Gm-Message-State: AOAM530FzHZ6IYr/ZPQKPiLun73NX61SW2Az4iaBNxrRr9YaVMotrWr4 51nIRGnpUgtVdKp/7zO10PeKtQ== X-Google-Smtp-Source: ABdhPJzLBqfP1XcXqob9kFKwAurSxWiBTNrBa1UAoCW3rOZKHRhfNNzkyCiKxxa+LBJw8i7jEfIOzw== X-Received: by 2002:a92:ae02:0:b0:2c6:798d:2be with SMTP id s2-20020a92ae02000000b002c6798d02bemr4402956ilh.18.1648198292138; Fri, 25 Mar 2022 01:51:32 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id z11-20020a92cd0b000000b002c85ac49d2asm2607365iln.79.2022.03.25.01.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 01:51:31 -0700 (PDT) Date: Fri, 25 Mar 2022 08:51:28 +0000 From: Oliver Upton To: Reiji Watanabe Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux ARM , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Will Deacon , Andrew Jones , Fuad Tabba , Peng Liang , Peter Shier , Ricardo Koller , Jing Zhang , Raghavendra Rao Anata Subject: Re: [PATCH v6 11/25] KVM: arm64: Add remaining ID registers to id_reg_desc_table Message-ID: References: <20220311044811.1980336-1-reijiw@google.com> <20220311044811.1980336-12-reijiw@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Mar 24, 2022 at 10:15:41PM -0700, Reiji Watanabe wrote: > On Thu, Mar 24, 2022 at 4:01 PM Oliver Upton wrote: > > > > On Thu, Mar 24, 2022 at 01:23:42PM -0700, Reiji Watanabe wrote: > > > Hi Oliver, > > > > > > On Wed, Mar 23, 2022 at 12:53 PM Oliver Upton wrote: > > > > > > > > Hi Reiji, > > > > > > > > On Thu, Mar 10, 2022 at 08:47:57PM -0800, Reiji Watanabe wrote: > > > > > Add hidden or reserved ID registers, and remaining ID registers, > > > > > which don't require special handling, to id_reg_desc_table. > > > > > Add 'flags' field to id_reg_desc, which is used to indicates hiddden > > > > > or reserved registers. Since now id_reg_desc_init() is called even > > > > > for hidden/reserved registers, change it to not do anything for them. > > > > > > > > > > Signed-off-by: Reiji Watanabe > > > > > > > > I think there is a very important detail of the series that probably > > > > should be highlighted. We are only allowing AArch64 feature registers to > > > > be configurable, right? AArch32 feature registers remain visible with > > > > their default values passed through to the guest. If you've already > > > > stated this as a precondition elsewhere then my apologies for the noise. > > > > > > > > I don't know if adding support for this to AArch32 registers is > > > > necessarily the right step forward, either. 32 bit support is working > > > > just fine and IMO its OK to limit new KVM features to AArch64-only so > > > > long as it doesn't break 32 bit support. Marc of course is the authority > > > > on that, though :-) > > > > > > > > If for any reason a guest uses a feature present in the AArch32 feature > > > > register but hidden from the AArch64 register, we could be in a > > > > particularly difficult position. Especially if we enabled traps based on > > > > the AArch64 value and UNDEF the guest. > > > > > > > > One hack we could do is skip trap configuration if AArch32 is visible at > > > > either EL1 or EL0, but that may not be the most elegant solution. > > > > Otherwise, if we are AArch64-only at every EL then the definition of the > > > > AArch32 feature registers is architecturally UNKNOWN, so we can dodge > > > > the problem altogether. What are your thoughts? > > > > > > Thank you so much for your review, Oliver! > > > > > > For aarch32 guests (when KVM_ARM_VCPU_EL1_32BIT is configured), > > > yes, the current series is problematic as you mentioned... > > > I am thinking of disallowing configuring ID registers (keep ID > > > registers immutable) for the aarch32 guests for now at least. > > > (will document that) > > > > That fixes it halfway, but the AArch64 views of the AArch32 feature > > registers have meaning even if AArch32 is defined at EL0. The only time > > they are architecturally UNKNOWN is if AArch32 is not implemented at any > > EL visible to the guest. > > > > So, given that: > > > > > For aarch64 guests that support EL0 aarch32, it would generally > > > be a userspace bug if userspace sets inconsistent values in 32bit > > > and 64bit ID registers. KVM doesn't provide a complete consistency > > > checking for ID registers, but this could be added later as needed. > > > > I completely agree that there is a large set of things that can be swept > > under the rug of userspace bugs. If we are going to do that, we need to > > strongly assert that configurable feature registers is only for fully > > AArch64-only guests. Additionally, strong documentation around these > > expectations is required. > > Just to be clear, what I meant "this could be added later" is that > the feature consistency checking between 64bit ID registers and 32bit ID > registers could be added later. It means configuring ID registers > itself will be allowed for EL1 aarch64 guests including ones that > support EL0 aarch32 (but not for EL1 aarch32 guests). > I believe we are in agreement then. I don't believe there is any need to prohibit register accesses for the case of AArch32 EL1, given the fact that it is impossible to read the ID_AA64*_EL1 registers from the guest anyway. We can go ahead and let userspace play with those registers as much as it wants, it delightfully has no affect :) > > Mind you, these opinions are my own and IDK how others or Marc feel > > about it. My read of the situation w.r.t. the AArch32 registers is that > > it will become a mess to implement on top of the AArch64 registers. > > Given the fact that we aren't breaking AArch32 VMs, only augmenting > > behavior for AArch64, it seems OK. > > Thank you for sharing your thoughts. > They look almost the same as what I've been thinking. > > Thanks, > Reiji > > > > But I would genuinely love to be wrong on this topic too. I just don't > > have perspective on AArch32 users so it is hard to really say whether > > this is something they need as well.