Date: Mon, 21 Mar 2022 12:40:46 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Christophe Branchereau <cbranchereau@gmail.com>
Subject: Re: [PATCH v4 2/4] drm/panel: Add panel driver for NewVision NV3052C
 based LCDs
Message-ID: <YjhkPnr46IOy5iS+@ravnborg.org>
References: <20220311170240.173846-1-cbranchereau@gmail.com>
 <20220311170240.173846-3-cbranchereau@gmail.com>
 <YjD1rl7jSxLvJhfL@ravnborg.org>
 <CAFsFa87NBB8VFFHJKjyPi+A255i9dyE-xxTggz3kLcEXmSWJXg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFsFa87NBB8VFFHJKjyPi+A255i9dyE-xxTggz3kLcEXmSWJXg@mail.gmail.com>
Precedence: list
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
 linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
 linux-mips@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>,
 Thierry Reding <thierry.reding@gmail.com>, dri-devel@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>

Hi Christophe,

> > > +     { 0x0d, 0x58 },
> > > +     { 0x0e, 0x48 },
> > > +     { 0x0f, 0x38 },
> > > +     { 0x10, 0x2b },
> > > +
> > > +     { 0xff, 0x30 },
> > > +     { 0xff, 0x52 },
> > > +     { 0xff, 0x00 },
> > > +     { 0x36, 0x0a },
> > > +};
> > There are some random (?) empty lines.
> > If they have any significance then a short comment would be nice.
> > If not, then drop the empty lines.
> >
> 
> The empty lines are not random no, to access a different page in the
> init, one must write i.e.   { 0xff, 0x30 }, { 0xff, 0x52 }, { 0xff,
> 0x02 }, to access page 2, so they add a little bit of readability.
Then I suggest to just say what page is is like:

	/* Page 1 */
	{ 0xff, 0x30 },
	...

Etc. then it is obvious this is page boundaries.

	Sam