Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DFA1C433EF for ; Thu, 24 Mar 2022 14:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350821AbiCXOgY (ORCPT ); Thu, 24 Mar 2022 10:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348570AbiCXOgX (ORCPT ); Thu, 24 Mar 2022 10:36:23 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3F6ABAE for ; Thu, 24 Mar 2022 07:34:50 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1nXOY5-0003RM-0N; Thu, 24 Mar 2022 15:34:49 +0100 Date: Thu, 24 Mar 2022 15:34:49 +0100 From: Phil Sutter To: Florian Westphal Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [nf-next PATCH 2/2] netfilter: nf_log_syslog: Don't ignore unknown protocols Message-ID: Mail-Followup-To: Phil Sutter , Florian Westphal , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20220324140341.24259-1-phil@nwl.cc> <20220324140341.24259-2-phil@nwl.cc> <20220324141614.GC24666@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324141614.GC24666@breakpoint.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Mar 24, 2022 at 03:16:14PM +0100, Florian Westphal wrote: > Phil Sutter wrote: > > With netdev and bridge nfprotos, loggers may see arbitrary ethernet > > frames. Print at least basic info like interfaces and MAC header data. > > Makes sense to me. > > > + /* FIXME: Disabled from containers until syslog ns is supported */ > > + if (!net_eq(net, &init_net) && !sysctl_nf_log_all_netns) > > + return; > > Hmm, this is now the 3rd incarnation of this comment + check, > perhaps create another patch that adds a helper? Yes, I thought about that already but found it not worth it. OTOH, copying outdated comments is a sin so I'll submit a follow-up. Thanks, Phil