Content-Type: multipart/mixed; boundary="===============2831575405205658936==" MIME-Version: 1.0 From: Peter Xu To: kbuild-all@lists.01.org Subject: Re: [PATCH v8 15/23] mm/hugetlb: Handle pte markers in page faults Date: Wed, 06 Apr 2022 11:02:12 -0400 Message-ID: In-Reply-To: <202204062154.2txNJyaf-lkp@intel.com> List-Id: --===============2831575405205658936== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Apr 06, 2022 at 09:37:00PM +0800, kernel test robot wrote: > Hi Peter, > = > Thank you for the patch! Yet something to improve: > = > [auto build test ERROR on hnaz-mm/master] > [cannot apply to arnd-asm-generic/master linus/master linux/master v5.18-= rc1 next-20220406] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/userfault= fd-wp-Support-shmem-and-hugetlbfs/20220405-100136 > base: https://github.com/hnaz/linux-mm master > config: s390-randconfig-r044-20220406 (https://download.01.org/0day-ci/ar= chive/20220406/202204062154.2txNJyaf-lkp(a)intel.com/config) > compiler: s390-linux-gcc (GCC) 11.2.0 > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/e7e7aaec811e2817c= d169f0cc1d8f81bdf1f05c3 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Peter-Xu/userfaultfd-wp-Support-= shmem-and-hugetlbfs/20220405-100136 > git checkout e7e7aaec811e2817cd169f0cc1d8f81bdf1f05c3 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cro= ss O=3Dbuild_dir ARCH=3Ds390 SHELL=3D/bin/bash > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All errors (new ones prefixed by >>): > = > mm/hugetlb.c: In function 'hugetlb_fault': > >> mm/hugetlb.c:5678:13: error: implicit declaration of function 'huge_pt= e_none_mostly'; did you mean 'pte_none_mostly'? [-Werror=3Dimplicit-functio= n-declaration] > 5678 | if (huge_pte_none_mostly(entry)) { > | ^~~~~~~~~~~~~~~~~~~~ > | pte_none_mostly > cc1: some warnings being treated as errors Ah, the s390 stub was forgotten again, sorry. I hope someday s390 will start to include asm-generic/hugetlb.h like all the rest archs, because that's really from the gut feeling of how it should happen.. or the dir should be renamed to asm-generic-without-s390/. :( An expected fix patch attached (to be squashed into patch "mm: Introduce PTE_MARKER swap entry"). Thanks, -- = Peter Xu --===============2831575405205658936== Content-Type: text/plain MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-fixup-mm-Introduce-PTE_MARKER-swap-entry.patch" RnJvbSA4Yjg0ZDdmNmI4NmMzMDYyMzIwOGVmZjM4NmI0ZjUxNjlmMWNiMGRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBYdSA8cGV0ZXJ4QHJlZGhhdC5jb20+CkRhdGU6IFdl ZCwgNiBBcHIgMjAyMiAxMDo1NTo1NSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIGZpeHVwISBtbTog SW50cm9kdWNlIFBURV9NQVJLRVIgc3dhcCBlbnRyeQoKU2lnbmVkLW9mZi1ieTogUGV0ZXIgWHUg PHBldGVyeEByZWRoYXQuY29tPgotLS0KIGFyY2gvczM5MC9pbmNsdWRlL2FzbS9odWdldGxiLmgg fCA1ICsrKysrCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEv YXJjaC9zMzkwL2luY2x1ZGUvYXNtL2h1Z2V0bGIuaCBiL2FyY2gvczM5MC9pbmNsdWRlL2FzbS9o dWdldGxiLmgKaW5kZXggYmU5OWVkYTg3ZjRkLi4zMmMzZmQ2ZTg3OGUgMTAwNjQ0Ci0tLSBhL2Fy Y2gvczM5MC9pbmNsdWRlL2FzbS9odWdldGxiLmgKKysrIGIvYXJjaC9zMzkwL2luY2x1ZGUvYXNt L2h1Z2V0bGIuaApAQCAtODUsNiArODUsMTEgQEAgc3RhdGljIGlubGluZSBpbnQgaHVnZV9wdGVf bm9uZShwdGVfdCBwdGUpCiAJcmV0dXJuIHB0ZV9ub25lKHB0ZSk7CiB9CiAKK3N0YXRpYyBpbmxp bmUgaW50IGh1Z2VfcHRlX25vbmVfbW9zdGx5KHB0ZV90IHB0ZSkKK3sKKwlyZXR1cm4gaHVnZV9w dGVfbm9uZShwdGUpOworfQorCiBzdGF0aWMgaW5saW5lIGludCBodWdlX3B0ZV93cml0ZShwdGVf dCBwdGUpCiB7CiAJcmV0dXJuIHB0ZV93cml0ZShwdGUpOwotLSAKMi4zMi4wCgo= --===============2831575405205658936==--