Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA375C433EF for ; Tue, 29 Mar 2022 06:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232972AbiC2GTi (ORCPT ); Tue, 29 Mar 2022 02:19:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232970AbiC2GTh (ORCPT ); Tue, 29 Mar 2022 02:19:37 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A322B248785 for ; Mon, 28 Mar 2022 23:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5ThWZktK4IezOUxdfJeExTpN9u9U7UQF8A25Xtos3Xw=; b=AX3b5YMReg+9ECj8fH8sTHKYN7 nv0lZxyfav0fRZ6mJAQGSZdj+pHnNk2VkrXM+Ky5G8iup0CuNrO/GTVrn1y3N39tHuTftVt97gjbq gjX/bcsz+e/33dKJq6oOV/JhP50E9Uc+BfPJyj2WQHjEXYoqmqld6J47YEhL0WNsMlcEF6rMKKu9o ExY+0+DufWJaLxxLGm8vRdA93sX8UhfbSmmc0FTRrs/NQwEIs1T+sR4IP4hJZcUWXEyq4rVBbpFeq obzpeub0gKsRGEbWyFfWtyRLLZhFEZy0r3lDLiSUdGE73rP5ptUpnOWhnwFPVSbTdwQrCogHpkqI0 rnYdjiJQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ5Au-00BBcU-Sl; Tue, 29 Mar 2022 06:17:52 +0000 Date: Mon, 28 Mar 2022 23:17:52 -0700 From: Christoph Hellwig To: Qu Wenruo Cc: Sweet Tea Dorminy , Christoph Hellwig , Qu Wenruo , linux-btrfs@vger.kernel.org Subject: Re: [PATCH RFC 2/2] btrfs: do data read repair in synchronous mode Message-ID: References: <1b796a483efa008ba5e2090621161684b3c4109b.1648201268.git.wqu@suse.com> <84178851-8c88-dea1-1d0e-844b6ba7bb7c@gmx.com> <7225af7b-eec3-b5a4-fa4c-6333fae5ac4d@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7225af7b-eec3-b5a4-fa4c-6333fae5ac4d@gmx.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sat, Mar 26, 2022 at 09:10:51AM +0800, Qu Wenruo wrote: > Thanks for your hint on this, the more correct term is, btrfs always > iterate the bvec using single page helper, bio_for_each_segment_all(). > > Thus even if the bvec has multiple pages in it, we still treat it as > single page using bvec_iter. Yes, like most file systems.