Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C36867A for ; Sun, 3 Apr 2022 08:05:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1D52C340F3; Sun, 3 Apr 2022 08:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648973141; bh=opLcU29acddtyzVufVbpjteyPfDjI2D8KSG2MV5cu5E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=itvPRJ+VsbzbyFqRiaYrWg4A/np9jYWjHGsUZkd7IZ1bFsDvbIaqgV/6ZYJh09DHr RKIIdttb6Zs3cS9BHYUy2REpwnJlaOxpK+QtNLTA7zgivUGx3B+tqpoBJHhyFBR/Bs 7AeWRX4HyXdLXoKhupHVFPTC+hwE0dX5ZSkslS2cMcgNjGhEdLBkFeEE98JxkNItIl K/nDVyxJgiHVXljkdpOIvNi4OMcEbNiDOANdRcSRJmyzox/OKLDI+qHYvlDevKIaMc PBU7FhdbZU6j7cONoag7C9SHZxjzY5A2G1bcvjSRTGanHnQsCFQtEoeSwtijirtzWK ni6ogFRjzI0og== Date: Sun, 3 Apr 2022 11:06:51 +0300 From: Jarkko Sakkinen To: Michal Orzel , David Howells Cc: James Morris , "Serge E. Hallyn" , Nathan Chancellor , Nick Desaulniers , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 3/5] keys: Remove redundant assignments Message-ID: References: <20220331173358.40939-1-michalorzel.eng@gmail.com> <20220331173358.40939-3-michalorzel.eng@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331173358.40939-3-michalorzel.eng@gmail.com> On Thu, Mar 31, 2022 at 07:33:56PM +0200, Michal Orzel wrote: > Get rid of redundant assignments which end up in values not being > read either because they are overwritten or the function ends. > > Reported by clang-tidy [deadcode.DeadStores] > > Signed-off-by: Michal Orzel > --- > security/keys/process_keys.c | 1 - > security/keys/request_key.c | 6 ++---- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c > index b5d5333ab330..8bdd6410f79a 100644 > --- a/security/keys/process_keys.c > +++ b/security/keys/process_keys.c > @@ -92,7 +92,6 @@ int look_up_user_keyrings(struct key **_user_keyring, > return PTR_ERR(reg_keyring); > > down_write(&user_ns->keyring_sem); > - ret = 0; > > /* Get the user keyring. Note that there may be one in existence > * already as it may have been pinned by a session, but the user_struct > diff --git a/security/keys/request_key.c b/security/keys/request_key.c > index 2da4404276f0..ad29023c9518 100644 > --- a/security/keys/request_key.c > +++ b/security/keys/request_key.c > @@ -116,7 +116,7 @@ static int call_sbin_request_key(struct key *authkey, void *aux) > { > static char const request_key[] = "/sbin/request-key"; > struct request_key_auth *rka = get_request_key_auth(authkey); > - const struct cred *cred = current_cred(); > + const struct cred *cred; > key_serial_t prkey, sskey; > struct key *key = rka->target_key, *keyring, *session, *user_session; > char *argv[9], *envp[3], uid_str[12], gid_str[12]; > @@ -506,9 +506,7 @@ static struct key *construct_key_and_link(struct keyring_search_context *ctx, > kdebug("cons failed"); > goto construction_failed; > } > - } else if (ret == -EINPROGRESS) { > - ret = 0; > - } else { > + } else if (ret != -EINPROGRESS) { > goto error_put_dest_keyring; > } > > -- > 2.25.1 > Acked-by: Jarkko Sakkinen David: can you pick this? BR, Jarkko