Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A58DC433FE for ; Tue, 5 Apr 2022 21:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347896AbiDEVXH (ORCPT ); Tue, 5 Apr 2022 17:23:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1457970AbiDERCV (ORCPT ); Tue, 5 Apr 2022 13:02:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 334F788B0E; Tue, 5 Apr 2022 10:00:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C272C615AF; Tue, 5 Apr 2022 17:00:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4FBBC385A5; Tue, 5 Apr 2022 17:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649178022; bh=zb1JFQP4vJ/gYj1rlsoqkkSJjt4zifG3LrmGqsQ055U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LKBetFmeA75o9XU4QGhMx54eDMYGRe6Polah3FawFP3ub9F9PvXz8KyjNQwvnu8hG 20c1vv60qUF70wyTBjWbRC3ZyrFXVxWxbD6Jp1sWltN7+VJhhrdGESUJLulGn4yoCg UtkoFG8fjZROl67hOi1TfLJt66UAX2gCLwW7nCOg= Date: Tue, 5 Apr 2022 19:00:19 +0200 From: Greg Kroah-Hartman To: dann frazier Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Marc Zyngier , Lorenzo Pieralisi , Rob Herring , Toan Le , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , =?iso-8859-1?Q?St=E9phane?= Graber Subject: Re: [PATCH 5.16 0199/1017] PCI: xgene: Revert "PCI: xgene: Fix IB window setup" Message-ID: References: <20220405070354.155796697@linuxfoundation.org> <20220405070400.156176848@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 05, 2022 at 09:42:37AM -0600, dann frazier wrote: > On Tue, Apr 05, 2022 at 09:18:32AM +0200, Greg Kroah-Hartman wrote: > > From: Marc Zyngier > > > > commit 825da4e9cec68713fbb02dc6f71fe1bf65fe8050 upstream. > > > > Commit c7a75d07827a ("PCI: xgene: Fix IB window setup") tried to > > fix the damages that 6dce5aa59e0b ("PCI: xgene: Use inbound resources > > for setup") caused, but actually didn't improve anything for some > > plarforms (at least Mustang and m400 are still broken). > > > > Given that 6dce5aa59e0b has been reverted, revert this patch as well, > > restoring the PCIe support on XGene to its pre-5.5, working state. > > > > Link: https://lore.kernel.org/r/YjN8pT5e6/8cRohQ@xps13.dannf > > Link: https://lore.kernel.org/r/20220321104843.949645-3-maz@kernel.org > > Fixes: c7a75d07827a ("PCI: xgene: Fix IB window setup") > > Signed-off-by: Marc Zyngier > > Signed-off-by: Lorenzo Pieralisi > > Cc: stable@vger.kernel.org > > Cc: Rob Herring > > Cc: Toan Le > > Cc: Lorenzo Pieralisi > > Cc: Krzysztof Wilczyński > > Cc: Bjorn Helgaas > > Cc: Stéphane Graber > > Cc: dann frazier > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/pci/controller/pci-xgene.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hi Greg, > > I don't think it makes sense to apply this to 5.10.y, 5.15.y & > 5.16.y w/o also applying a backport of 1874b6d7ab1, because without > that we will regress support for Stéphane's X-Gene2-based systems. The > backport of 1874b6d7ab1 was rejected for these trees because it doesn't > apply cleanly, but I've just submitted new versions that do. Where were those patches sent to? I don't seem to see them on the stable list, did I miss them? thanks, greg k-h