Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65931C433F5 for ; Mon, 11 Apr 2022 21:00:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348944AbiDKVCW (ORCPT ); Mon, 11 Apr 2022 17:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234574AbiDKVCV (ORCPT ); Mon, 11 Apr 2022 17:02:21 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED86F2A725 for ; Mon, 11 Apr 2022 14:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Pk8iVSdGCpenj2GLsLc4wJaW0usHCGPG0X8zd6virmA=; b=svn5Vvtymnuw0B8B07dk+HOPrf 4z5x7GtHDnTOHP27AE+Pm1l0CiHaZbh9EKReRHUAxdamr8rSiaWJvKbhjWCpiC1c8YOL0Gt7a2+2L OVFaztKxieZpgFY5yEW4BbGDI++CeEyeZ9JDLXlEK7elRsJhwmw+u/kdApgeDwURZIb8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ne18h-00FK8u-4s; Mon, 11 Apr 2022 22:59:59 +0200 Date: Mon, 11 Apr 2022 22:59:59 +0200 From: Andrew Lunn To: Jakub Kicinski Cc: Josua Mayer , Krzysztof Kozlowski , netdev@vger.kernel.org, alvaro.karsz@solid-run.com, Michael Hennerich , "David S. Miller" , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Alexandru Ardelean Subject: Re: [PATCH 1/3] dt: adin: document clk-out property Message-ID: References: <20220410104626.11517-1-josua@solid-run.com> <20220410104626.11517-2-josua@solid-run.com> <20220411130715.516fc5cc@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220411130715.516fc5cc@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Noob question - can you explain how this property describes HW? > I thought we had a framework for clock config, and did not require > vendor specific properties of this sort. > > The recovered vs free running makes the entire thing sound like > a SyncE related knob, irrelevant to normal HW operation. It is not necessarily SyncE. Fast Ethernet is based around a 25MHz clock. Something needs to provide that clock. Sometimes the SoC/MAC provides it, and passes it to the PHY. Sometimes the PHY provides it, and passes it to the SoC/MAC. There are a couple of PHYs which make use of the common clock framework, when the SoC is the clock source. However, i don't think there are any PHYs which provide a clock to the common clock framework when they are the source. We do however have a number of vendor properties to control the PHY clock output, disable the PHY clock output, select the PHY clock output, etc. There is not too much standardisation here, and it is made worse by some PHYs needing a reset once the clock is ticking, some MACs stop the clock when the link is administrative down, some PHYs stop the clock a short time after the link goes down which can be bad for the MAC etc. Andrew