Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08A45C433EF for ; Thu, 21 Apr 2022 06:24:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B29A10F33C; Thu, 21 Apr 2022 06:24:42 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 87A5610E370 for ; Thu, 21 Apr 2022 06:24:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 53E33811B; Thu, 21 Apr 2022 06:21:49 +0000 (UTC) Date: Thu, 21 Apr 2022 09:24:39 +0300 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH 40/41] [TO BE REBASED] ARM: OMAP1: clock: Convert to CCF Message-ID: References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-41-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419133723.1394715-41-arnd@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, Dominik Brodowski , Lee Jones , Daniel Thompson , aaro.koskinen@iki.fi, Peter Ujfalusi , Helge Deller , jmkrzyszt@gmail.com, Russell King , Krzysztof Kozlowski , Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann , Mark Brown , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , Paul Walmsley , Jingoo Han , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Kevin Hilman , Vinod Koul , dmaengine@vger.kernel.org, alsa-devel@alsa-project.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Arnd Bergmann [220419 13:39]: > From: Janusz Krzysztofik > + /* protect clk->enable_reg from concurrent access via clk_set_rate() */ > + if (clk->enable_reg == OMAP1_IO_ADDRESS(ARM_CKCTL)) > + spin_lock_irqsave(&arm_ckctl_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(ARM_IDLECT2)) > + spin_lock_irqsave(&arm_idlect2_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(MOD_CONF_CTRL_0)) > + spin_lock_irqsave(&mod_conf_ctrl_0_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(MOD_CONF_CTRL_1)) > + spin_lock_irqsave(&mod_conf_ctrl_1_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(SWD_CLK_DIV_CTRL_SEL)) > + spin_lock_irqsave(&swd_clk_div_ctrl_sel_lock, flags); > + Eventually there should be just separate clock controller instances for the clock registers banks, and then this should all disappear as the lock is instance specific. Anyways, that's probably best done as a separate changes later on. Regards, Tony