Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6672AC433F5 for ; Thu, 21 Apr 2022 06:32:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 79A5810F4B8; Thu, 21 Apr 2022 06:32:07 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id B712E10F4B8 for ; Thu, 21 Apr 2022 06:32:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F2B92811B; Thu, 21 Apr 2022 06:29:13 +0000 (UTC) Date: Thu, 21 Apr 2022 09:32:03 +0300 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH 24/41] ARM: omap: un-merge plat/sram.c Message-ID: References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-25-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419133723.1394715-25-arnd@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, Dominik Brodowski , Lee Jones , Daniel Thompson , aaro.koskinen@iki.fi, Peter Ujfalusi , Helge Deller , jmkrzyszt@gmail.com, Russell King , Krzysztof Kozlowski , Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann , Mark Brown , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , Paul Walmsley , Jingoo Han , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Kevin Hilman , Vinod Koul , dmaengine@vger.kernel.org, alsa-devel@alsa-project.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Arnd Bergmann [220419 13:37]: > From: Arnd Bergmann > > The sram initialization code is the only shared omap1/2 code that > is not a standalone driver, but it is very short. Having two copies > of this code means some duplication of the sources, but actually > saves object code size as it can be inlined better. FYI, the sram code should eventually be updated to use drivers/misc/sram.c, I recall there being some issues to deal with for PM related code though. Probably the PM related save and restore could be now handled with cpu_pm. Regards, Tony