Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13F34625 for ; Tue, 26 Apr 2022 09:38:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AF85C385AC; Tue, 26 Apr 2022 09:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650965936; bh=FdzOrQvu6++ib5497R4Q/t3fH8Hdc4IvABGbNTHGKD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v+MU+Cjd4eesuiIinuoZTHr+o7j2+bx94ceCitEXGWDobcfG+sszcaZdghJhMwptr Er7AkoVhe/hjOp/o4en29iCBis3I2920BLtqGqeXRY4yeRSMcOF7LO4STOWZ7R8cqq rQFvfAawxhOEI1nlpye5MtJBEEGghYp2lHC0SQsI= Date: Tue, 26 Apr 2022 11:38:53 +0200 From: Greg Kroah-Hartman To: Philipp Hortmann Cc: Forest Bond , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD Message-ID: References: <2a50f3e99b15db2100f93e1e1a2b5cbc13b82882.1650784817.git.philipp.g.hortmann@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a50f3e99b15db2100f93e1e1a2b5cbc13b82882.1650784817.git.philipp.g.hortmann@gmail.com> On Sun, Apr 24, 2022 at 09:44:11AM +0200, Philipp Hortmann wrote: > Replace macro MACvReadMIBCounter with VNSvInPortD. > Last patch within this patch series will replace all macros > VNSvInPortD with ioread32. The names of macros and the arguments > use CamelCase which is not accepted by checkpatch.pl No need to say "last patch" as that will not make sense when these are in the tree, right? > > Since there are more than one checkpatch issue per line, > more steps are rquired to fix. This sentance also is not needed. So the changelog can just say: Replace macro MACvReadMIBCounter with VNSvInPortD and as it was the only user, it can now be removed. Same comments on the other changes in this series, but I did take the first patch, it made sense on its own. thanks, greg k-h