Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4477DC433EF for ; Thu, 28 Apr 2022 12:21:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346151AbiD1MYm (ORCPT ); Thu, 28 Apr 2022 08:24:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346140AbiD1MYl (ORCPT ); Thu, 28 Apr 2022 08:24:41 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4514822BC3 for ; Thu, 28 Apr 2022 05:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=5+Lq/NDQo/x/y4UMLoiISDBIJiIKMRhXgnKhy9Dy+ig=; b=nTVkl41oU7+WfOM5RXDl68Ejid xBL3oEne5T39Xm3JxMQjLLrZOMFriPrRVPXIXwVQlq238O/8dSiyIL3rfzTl87nmcMqbJJs64HROM DpxrOrgUuGJVwAl0J1w1i2CJ40OhfebhDPLYjoAMhdK97nB1hSVCL5cJH6UAubRRhnFk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nk398-000IRt-Cj; Thu, 28 Apr 2022 14:21:22 +0200 Date: Thu, 28 Apr 2022 14:21:22 +0200 From: Andrew Lunn To: Josua Mayer Cc: netdev@vger.kernel.org, alvaro.karsz@solid-run.com, Michael Hennerich , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH v3 2/3] net: phy: adin: add support for clock output Message-ID: References: <20220419102709.26432-1-josua@solid-run.com> <20220428082848.12191-1-josua@solid-run.com> <20220428082848.12191-3-josua@solid-run.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220428082848.12191-3-josua@solid-run.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +static int adin_config_clk_out(struct phy_device *phydev) > +{ > + struct device *dev = &phydev->mdio.dev; > + const char *val = NULL; > + u8 sel = 0; > + > + device_property_read_string(dev, "adi,phy-output-clock", &val); > + if(!val) { I'm pretty sure the coding style requires a space between if and (. Did you use checkpatch on this? Andrew