Content-Type: multipart/mixed; boundary="===============5415733628869568885==" MIME-Version: 1.0 From: Greg Kroah-Hartman To: kbuild-all@lists.01.org Subject: Re: [PATCH 5.10] arm: remove CONFIG_ARCH_HAS_HOLES_MEMORYMODEL Date: Thu, 12 May 2022 15:47:20 +0200 Message-ID: In-Reply-To: <20220510171523.98999-1-rppt@kernel.org> List-Id: --===============5415733628869568885== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, May 10, 2022 at 08:15:23PM +0300, Mike Rapoport wrote: > From: Mike Rapoport > = > commit 5e545df3292fbd3d5963c68980f1527ead2a2b3f upstream. > = > ARM is the only architecture that defines CONFIG_ARCH_HAS_HOLES_MEMORYMOD= EL > which in turn enables memmap_valid_within() function that is intended to > verify existence of struct page associated with a pfn when there are hol= es > in the memory map. > = > However, the ARCH_HAS_HOLES_MEMORYMODEL also enables HAVE_ARCH_PFN_VALID > and arch-specific pfn_valid() implementation that also deals with the hol= es > in the memory map. > = > The only two users of memmap_valid_within() call this function after > a call to pfn_valid() so the memmap_valid_within() check becomes redundan= t. > = > Remove CONFIG_ARCH_HAS_HOLES_MEMORYMODEL and memmap_valid_within() and re= ly > entirely on ARM's implementation of pfn_valid() that is now enabled > unconditionally. > = > Link: https://lkml.kernel.org/r/20201101170454.9567-9-rppt(a)kernel.org > Signed-off-by: Mike Rapoport > Cc: Alexey Dobriyan > Cc: Catalin Marinas > Cc: Geert Uytterhoeven > Cc: Greg Ungerer > Cc: John Paul Adrian Glaubitz > Cc: Jonathan Corbet > Cc: Matt Turner > Cc: Meelis Roos > Cc: Michael Schmitz > Cc: Russell King > Cc: Tony Luck > Cc: Vineet Gupta > Cc: Will Deacon > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > Reported-by: kernel test robot > Fixes: 8dd559d53b3b ("arm: ioremap: don't abuse pfn_valid() to check if p= fn is in RAM") > Signed-off-by: Mike Rapoport > --- > Documentation/vm/memory-model.rst | 3 +-- > arch/arm/Kconfig | 8 ++------ > arch/arm/mach-bcm/Kconfig | 1 - > arch/arm/mach-davinci/Kconfig | 1 - > arch/arm/mach-exynos/Kconfig | 1 - > arch/arm/mach-highbank/Kconfig | 1 - > arch/arm/mach-omap2/Kconfig | 1 - > arch/arm/mach-s5pv210/Kconfig | 1 - > arch/arm/mach-tango/Kconfig | 1 - > fs/proc/kcore.c | 2 -- > include/linux/mmzone.h | 31 ------------------------------- > mm/mmzone.c | 14 -------------- > mm/vmstat.c | 4 ---- > 13 files changed, 3 insertions(+), 66 deletions(-) Both now queued up, thanks. greg k-h --===============5415733628869568885==--