Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FFE4C433F5 for ; Wed, 4 May 2022 08:53:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94E5210FB81; Wed, 4 May 2022 08:53:17 +0000 (UTC) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F6F810FB81 for ; Wed, 4 May 2022 08:53:16 +0000 (UTC) Received: by mail-ej1-x62b.google.com with SMTP id y3so1534487ejo.12 for ; Wed, 04 May 2022 01:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=FWeYiYf0DMm7V+g21Cbm+9C9Pn1oqo14ZQ670Fj9soM=; b=H3LWFD2SKqhgrKGammVqLPu1+tsxAB77OiaspD7wNyK6giB6LGiCB0egmuFelRz0xd Wwr8iW5bq7rM304cdd3tRii/BntL55bHQGs59Jj+dRjdM5XT8vOzIahu7OZtSg/9zgsA PYg9GxvGp61ZKK8xDG4sWyfqcA89Y++1uLPP0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=FWeYiYf0DMm7V+g21Cbm+9C9Pn1oqo14ZQ670Fj9soM=; b=vAcqmF8chduO7LRNH9wU9hgnTB4J+S7c0tV2mkZ/rbgj3NK0Xi3jbEyDoXnCs4Zqim VrHtd5y79hUBIoDKFgCtf9XWGwZz3A4QGYKeZBKnbaAH4+HsF5wgTWiN0Pl4PLZaHt99 xANTcj7QuqCOgWtVf/hchg9NVdHM2Bhxy3zw5ZbmNvEwL44cJHqVoLc0MIJLaq0SEM4o gNVkH9WoyB/Htar0fQyQ3+u63riPAhVthpQEV0lm3vM85kz3DgHgZ/BTjFgWzSFL5wpE RjlndjmcmyS6qBY6QRhZpx8vY07QwD75Z9jUAxXUK6lcRXIe+pnVzlVWC+jasKrxQh+K IRXg== X-Gm-Message-State: AOAM530NMfKsSHWWhCNag6dPppDhl/Mha8sNmUXxQfKPsRdad7DksdCK Jc3CbdOzk/HlcCKnR38qFPivIA== X-Google-Smtp-Source: ABdhPJynePYca4h8hGIO/ma6nS7rL//o7qYPz+d7uodB/VCGwalHggLOksWn/GzUnOuMimdixtbeHg== X-Received: by 2002:a17:907:50a3:b0:6f3:a302:96aa with SMTP id fv35-20020a17090750a300b006f3a30296aamr18975623ejc.2.1651654395002; Wed, 04 May 2022 01:53:15 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id gz21-20020a170907a05500b006f3ef214e3csm5502964ejc.162.2022.05.04.01.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 01:53:14 -0700 (PDT) Date: Wed, 4 May 2022 10:53:12 +0200 From: Daniel Vetter To: Maxime Ripard Subject: Re: [PATCH] drm/todo: Add entry for using kunit in the subsystem Message-ID: Mail-Followup-To: Maxime Ripard , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Thomas Zimmermann , David Airlie , Jonathan Corbet , Maarten Lankhorst , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org References: <20220504080212.713275-1-javierm@redhat.com> <20220504081030.ky57nenipnif5r2e@houat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220504081030.ky57nenipnif5r2e@houat> X-Operating-System: Linux phenom 5.10.0-8-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , Jonathan Corbet , David Airlie , linux-doc@vger.kernel.org, Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, May 04, 2022 at 10:10:30AM +0200, Maxime Ripard wrote: > Hi, > > On Wed, May 04, 2022 at 10:02:12AM +0200, Javier Martinez Canillas wrote: > > The Kernel Unit Testing (KUnit) framework provides a common framework for > > unit tests within the Linux kernel. Having a test suite would allow to > > identify regressions earlier. > > > > Signed-off-by: Javier Martinez Canillas > > --- > > > > Documentation/gpu/todo.rst | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > index 127e76ee0b2d..10bfb50908d1 100644 > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -603,6 +603,20 @@ Level: Advanced > > Better Testing > > ============== > > > > +Add unit tests using the Kernel Unit Testing (KUnit) framework > > +-------------------------------------------------------------- > > + > > +The `KUnit `_ > > +provides a common framework for unit tests within the Linux kernel. Having a > > +test suite would allow to identify regressions earlier. > > + > > +A good candidate for the first unit tests are the format-conversion helpers in > > +``drm_format_helper.c``. > > + > > +Contact: Javier Martinez Canillas > > + > > +Level: Intermediate > > Kunit is fairly easy to grasp if you have some knowledge of other unit > testing frameworks already (pytest, cmocka, etc.) > > Another good candidate would be to convert (some ?) selftests to kunit. > I'm not sure the others, but at least test-drm_cmdline_parser should be > fairly easy to convert. All the drm selftest should be good candidates for conversion to kunit. Either way patch is Acked-by: Daniel Vetter Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch