Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10C13C433EF for ; Mon, 9 May 2022 09:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IHezI65vEbB+sjQHVn09Xo3q9zfCRFwQTJxNzOyYHzE=; b=GnIjCbN7ZuB/G3 8odOcVaUaYYmSKb6ddkHilws8nuCTzJSDtnrxYhas1zG4PWBuTDZE6MBwQ/VjPKWdGriY2e/kkjLK 12COqr6plKMTOzDNgD5+gZb70XXirrvVv7XYgAMAbUL3LMxTXX0ACossIRQI3ORRoDBwsSjAsaD9w vIQd5/vuoBHQe2rTjhTq+gLwzUigrQ/RvwadQIfsr6U97eWOdJiCCqUyhsFSiTzUlJ3XzkM/+TQ4a hd19pTYmX7OO5wsn2E3gTt74Kxej806BfvGDD2xpIUombS3X2uNeqbLlx4X4l/mPfBv7gw4d86Dgg 6I4xIS13+GfCUNZLs8Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnzgb-00DRs4-7Q; Mon, 09 May 2022 09:28:13 +0000 Received: from mga07.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnzgU-00DRm7-3A for linux-arm-kernel@lists.infradead.org; Mon, 09 May 2022 09:28:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652088486; x=1683624486; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jHBUo4IZJ5wDgySYfLtBXCx8yanDJE1x8luvraGTq3g=; b=ZXDMSQ6o0piPJYYzSTYhdJfeOuyLjx6zmA+TTtyFtDTn6qELk4r15N9p yf9AYHjiqUu5NpuLy+RIIV3s4VE8eiEkvANYyu5iWvZ+XweiOAEhDTSz7 dMfH1lNDw1RqwWTx94Q8ilrmfVgvq4ErxoxxQZis0aFU/wwe0yoOTgeZZ vqU6rJ6k3XR5kVawFhjCX8t5oh9/i/FAdS1XoGew0uIva34TX7adVPndd if7V+izI5Y+Tv+Br9sfaNyq/JLyAtbOMG1XegwGMFXMEGC8B1g51sYYrw rmURFj5HRrvXKkZ7aw8lBm6rnzbiWwA2f38E5IBfWfezfc4eAKqdiaT/H Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10341"; a="332027455" X-IronPort-AV: E=Sophos;i="5.91,211,1647327600"; d="scan'208";a="332027455" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2022 02:28:05 -0700 X-IronPort-AV: E=Sophos;i="5.91,211,1647327600"; d="scan'208";a="550934317" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2022 02:28:02 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nnzgN-00DrIB-Q6; Mon, 09 May 2022 12:27:59 +0300 Date: Mon, 9 May 2022 12:27:59 +0300 From: Andy Shevchenko To: Fabien DESSENNE Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Alexandre Torgue , kernel test robot Subject: Re: [PATCH v1 1/1] pinctrl: stm32: Unshadow np variable in stm32_pctl_probe() Message-ID: References: <20220507102257.26414-1-andriy.shevchenko@linux.intel.com> <30a2c669-693f-45ec-df0e-610e1f94bffd@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <30a2c669-693f-45ec-df0e-610e1f94bffd@foss.st.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_022806_229718_260022C6 X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 09, 2022 at 09:39:57AM +0200, Fabien DESSENNE wrote: > Hi Andy > > > Thank you for the patch. > > Will this patch be applied in Linus pinctrl tree, or in the gpio-intel tree > before being merged (linux-next) in the pinctrl tree? I believe the pin control tree is a primary here, while applying to GPIO tree won't harm. But I maintain neither of them :-) > On 07/05/2022 12:22, Andy Shevchenko wrote: > > The np variable is used globally for stm32_pctl_probe() and in one of > > its code branches. cppcheck is not happy with that: > > > > pinctrl-stm32.c:1530:23: warning: Local variable 'np' shadows outer variable [shadowVariable] > > > > Instead of simply renaming one of the variables convert some code to > > use a device pointer directly. > > > > Fixes: bb949ed9b16b ("pinctrl: stm32: Switch to use for_each_gpiochip_node() helper") > > Reported-by: kernel test robot > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Fabien Dessenne Thanks! -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel