Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16E3C433F5 for ; Tue, 10 May 2022 10:01:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239443AbiEJKF3 (ORCPT ); Tue, 10 May 2022 06:05:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239054AbiEJKFN (ORCPT ); Tue, 10 May 2022 06:05:13 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3B103EAB8; Tue, 10 May 2022 03:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652176876; x=1683712876; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8DH0BNbpwE8GijAGJt1CM+7tdMZJzjE1yk74ezgb6wg=; b=g/C5d34IjaChbxaAQMLxjHoaPTzK6beWw525cN3Tl3IAzYYAH+tPE9jY DsoW6ytsr6H+DhbRxTKL+NEgCL6z2QkKjwXpRr1ExJddhsfRKCkHkIfpG jqCyzQ0dVXjoczp6FdejjevuXCWGI7uPZIduUPO69C/2bc7k1yihZooI5 cZ78xOtF6QmM5mRuVEhW0ie/gGMKtVC2gdiMX4Kmw056Yk5HN/QdFYu/7 6EVEj7fZLIdtfjsV/T5oRt5hH8GdWsXBtjNDLD/3oua5ypbK6+nRjdIYm WPWM+qvRLGiupFYuJhkxRNm+VYj7QkUViPBrb6fyEhH7/xmP0CsC0F3/0 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10342"; a="269259525" X-IronPort-AV: E=Sophos;i="5.91,214,1647327600"; d="scan'208";a="269259525" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 03:01:16 -0700 X-IronPort-AV: E=Sophos;i="5.91,214,1647327600"; d="scan'208";a="541704741" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 03:01:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1noMfy-00EHy4-NP; Tue, 10 May 2022 13:01:06 +0300 Date: Tue, 10 May 2022 13:01:06 +0300 From: Andy Shevchenko To: "Martinez, Ricardo" Cc: Jakub Kicinski , Sergey Ryazanov , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, David Miller , Johannes Berg , Loic Poulain , M Chetan Kumar , "Devegowda, Chandrashekar" , Intel Corporation , chiranjeevi.rapolu@linux.intel.com, Haijun Liu =?utf-8?B?KCDliJjmtbflhpsp?= , "Hanania, Amir" , "Sharma, Dinesh" , "Lee, Eliot" , "Jarvinen, Ilpo Johannes" , "Veleta, Moises" , "Bossart, Pierre-louis" , "Sethuraman, Muralidharan" , "Mishra, Soumya Prakash" , "Kancharla, Sreehari" , "Sahu, Madhusmita" Subject: Re: [PATCH net-next v8 02/14] net: skb: introduce skb_data_area_size() Message-ID: References: <20220506181310.2183829-1-ricardo.martinez@linux.intel.com> <20220506181310.2183829-3-ricardo.martinez@linux.intel.com> <20220509094930.6d5db0f8@kernel.org> <20220509125008.6d1c3b9b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, May 09, 2022 at 02:37:26PM -0700, Martinez, Ricardo wrote: > On 5/9/2022 12:50 PM, Jakub Kicinski wrote: > > On Mon, 9 May 2022 21:34:58 +0300 Sergey Ryazanov wrote: ... > > We have two cases: > > - for Tx - drivers should use skb_headlen(); > > - for Rx - I presume we are either dealing with fresh or correctly > > reset skbs, so we can use skb_tailroom(). > Thanks for the information, looks like indeed we can avoid the helper in > t7xx driver by following those guidelines. I think this can be done as a follow up patch. -- With Best Regards, Andy Shevchenko