Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92916C433EF for ; Wed, 11 May 2022 17:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345681AbiEKRiF (ORCPT ); Wed, 11 May 2022 13:38:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236299AbiEKRiC (ORCPT ); Wed, 11 May 2022 13:38:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA6D1692AC for ; Wed, 11 May 2022 10:38:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 767E3B82153 for ; Wed, 11 May 2022 17:38:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DBBAC340EE; Wed, 11 May 2022 17:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652290679; bh=aCdJZ9j/PdDH2n+Soo73CJM408N6OH2MVsuqlRgTyUY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CcCUfm40CzRZ1Y6C96F/ZLkrgWClKU80ytqM1L6OU/pKGGDj5qyDlaRd06MG1OQA1 DnwUFFuzFcmuCOT/Ot3+GJ6cqqrHLIt/bWZVRkK4EyJDr8xlt9S2ReMHPRZk51EJ+e 3KLD9r1fQHa3k3XR9VQZehsHwT8LHOIFHNQCrT/sMfLmdr4mVvGv8aeiqIYeVykz6+ WEC0CvZd3Xd0br0at88Vf7aLP3dppquz5X9U7T+vsqUsXg04r6vT3Utm8fXuMZQP4F KvNN6vSYjo7BE/pTN4MwqVsmCXLxH2hV/BtBOzsg4WCf1AAP+muEcRoiK9zTWgLkkW fd2Cpf93nk+VQ== Date: Wed, 11 May 2022 10:37:57 -0700 From: Jaegeuk Kim To: Dan Carpenter Cc: Daeho Jeong , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Hi Dan, Thank you for the fix. If you don't mind, can I integrate this fix into the original patch which is in -next? Thanks, On 05/11, Dan Carpenter wrote: > Return an error code if f2fs_iget() fails. Currently it returns > success. > > Fixes: 3d7ad9c30607 ("f2fs: change the current atomic write way") > Signed-off-by: Dan Carpenter > --- > fs/f2fs/file.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 79d1a20fbda9..cd768fadfd67 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) > pinode = f2fs_iget(inode->i_sb, fi->i_pino); > if (IS_ERR(pinode)) { > f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > + ret = PTR_ERR(pinode); > goto out; > } > > -- > 2.35.1