Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D476BC433EF for ; Wed, 11 May 2022 16:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345237AbiEKQ6z (ORCPT ); Wed, 11 May 2022 12:58:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345231AbiEKQ6x (ORCPT ); Wed, 11 May 2022 12:58:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56FD513C4D6 for ; Wed, 11 May 2022 09:58:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1621AB82527 for ; Wed, 11 May 2022 16:58:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EB9EC340EE; Wed, 11 May 2022 16:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652288329; bh=MFyx3jlHxGnYLx6AEw97nvbi0segfIJE7X5BQtNQ52k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mh1n+FJ/x030Bk7iqG6nkPtfhmvGsScfwsP+uCwYMK+HWKHpgRywdG0wK91wrq7fE FFBSQa/1/sPoAUOvXGWE+N6LaH+aSPO1V6PaKJGr7BV5QYp3reVKsKaAWU/i/pgWmT Yr+H7/igt2cXhV+eaY7JWaCMO6frPKR7x0WRH+Fw= Date: Wed, 11 May 2022 18:58:46 +0200 From: Greg KH To: Alan Stern Cc: Geert Uytterhoeven , Felipe Balbi , USB mailing list Subject: Re: [PATCH] USB: gadget: Add ID numbers to gadget names Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, May 11, 2022 at 05:17:48PM +0200, Greg KH wrote: > On Tue, May 10, 2022 at 11:51:29AM -0400, Alan Stern wrote: > > Putting USB gadgets on a new bus of their own encounters a problem > > when multiple gadgets are present: They all have the same name! The > > driver core fails with a "sys: cannot create duplicate filename" error > > when creating any of the /sys/bus/gadget/devices/ > > symbolic links after the first. > > > > This patch fixes the problem by adding a ".N" suffix to each gadget's > > name when the gadget is registered (where N is a unique ID number), > > thus making the names distinct. > > > > Reported-and-tested-by: Geert Uytterhoeven > > Signed-off-by: Alan Stern > > Reviewed-by: Geert Uytterhoeven > > Fixes: fc274c1e9973 ("USB: gadget: Add a new bus for gadgets") > > > > --- > > > > > > [as1980] > > Thanks, let me run this through the Android test suite first. You can > see the results here: > https://android-review.googlesource.com/c/kernel/common/+/2095109 > > I'll let you know how it goes as I do not know if you are not logged in > if you can see the test results or not, gerrit is odd... All passed, so I'll go queue this up now, thanks! greg k-h