Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF58C433EF for ; Wed, 1 Jun 2022 12:14:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351778AbiFAMO0 (ORCPT ); Wed, 1 Jun 2022 08:14:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243225AbiFAMOY (ORCPT ); Wed, 1 Jun 2022 08:14:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2D385B8A4 for ; Wed, 1 Jun 2022 05:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LWYlnHCXMvtR6+GazaADN4X4ovZX4RIptYJyLbCBrdo=; b=wcb+Khtom0whtthrI8j2rdBStS g9nwe7o+6u3R3q1byC39DQLoBa2dixaRqC5jWvhYXi0HWo4G/j6wRuqqoWnLWPwsLcG9yPScBvk1g gyTTPnDehoBXX3CY7aPnCSJ6ahqU+lsyhaom7yY5lpUslrc0xJygj3eEmAk5GoqS7zwNpIrmyXADN XoT7xGmbFjM/087RmGDvXHWh03YiZJ2M6TB/nsazw3ft29i1PaHROXrcBEDm4k1nunP8a9vAdB4VR 07R+W4B2KswZoQwqf2zVxkAQ1A0TRYcI5I6NrWy2ZVDU0G1sh4m+HpqL0zQvTctvIkF3e+ll1EBCV atCLED8Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwNEz-00G0Sv-MG; Wed, 01 Jun 2022 12:14:21 +0000 Date: Wed, 1 Jun 2022 05:14:21 -0700 From: Christoph Hellwig To: David Sterba Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: remove redundant calls to flush_dcache_page Message-ID: References: <20220601114754.21771-1-dsterba@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220601114754.21771-1-dsterba@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Jun 01, 2022 at 01:47:54PM +0200, David Sterba wrote: > memzero_page already calls flush_dcache_page so we can remove the calls > from btrfs code. This is for a mix of memcpy_to_page and memzero_page, but the statement is true for both of them. So with a slightly fixed commit log: Reviewed-by: Christoph Hellwig