Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A182C433EF for ; Fri, 10 Jun 2022 15:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JMdkx5Wc+yxHcibkwAZYuJGesfTC+7CCHBEv1iQ+9J4=; b=pMi3rQGe80seJq g+8bC6nrMRp4E7oJy5+bIxwrvdGlhKjutcOSPVw8GqcRK988HO0Id2cGjtfnjnFjzHeyglqrIfOk3 n0XXwUcIBKIGhDCqeIOMyQJG+q2c5yxwAYUutnLuCya7gMfxTzD2b61+5+Fo383ewrE0Ufl9RsRIZ h3x8X/XuFsOB5EQr8DJBnhoSrgHSW/el+NVrwrf2Jtz1a10312DGpLAvrVesY9y33wBD4+ScEz2TE XxMyb1TDFqLho5+82uwi67kUui8SogMo7EnR95DkxsdjkPpP9A6fHOE8Pf5M1G01ZBnzNxgMCj0o/ C6mIeCbbrKgHRdq64vqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzgVw-008l7g-Ux; Fri, 10 Jun 2022 15:25:33 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzgVt-008l6W-Ps for linux-arm-kernel@lists.infradead.org; Fri, 10 Jun 2022 15:25:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 61224B8329C; Fri, 10 Jun 2022 15:25:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41F25C34114; Fri, 10 Jun 2022 15:25:23 +0000 (UTC) Date: Fri, 10 Jun 2022 16:25:19 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, kernel test robot Subject: Re: [PATCH v2] arm64/sme: Fix EFI save/restore Message-ID: References: <20220602124132.3528951-1-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220602124132.3528951-1-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_082530_018439_BF95EE30 X-CRM114-Status: GOOD ( 13.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 02, 2022 at 02:41:32PM +0200, Mark Brown wrote: > The EFI save/restore code is confused. When saving the check for saving > FFR is inverted due to confusion with the streaming mode check, and when > restoring we check if we need to restore FFR by checking the percpu > efi_sm_state without the required wrapper rather than based on the > combination of FA64 support and streaming mode. > > Fixes: e0838f6373e5 ("arm64/sme: Save and restore streaming mode over EFI runtime calls") > Reported-by: kernel test robot > Reviewed-by: Catalin Marinas > Signed-off-by: Mark Brown > --- > > Still not tested, that won't happen till next week. Did you get a chance to test this patch? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel