Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044BDC43334 for ; Tue, 14 Jun 2022 18:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232990AbiFNSer (ORCPT ); Tue, 14 Jun 2022 14:34:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232024AbiFNSeq (ORCPT ); Tue, 14 Jun 2022 14:34:46 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4292D48E78 for ; Tue, 14 Jun 2022 11:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ZAf46MHIlpiYiISuQ+pc0VZ/hLiIAOmVXaMY8kchKE8=; b=vQAmlb1Fn+yqxI+wsdoCtl2WN8 +chzMbRzKEbrLWEqEUe2QfxfyyYzRtdi7FmjBY24OFTxp4RgC5F4V7c9I6+IaKNKprOPOKAC2HGFM akWY+wbTRYjkE8YrZQzk0XXm9b4Lf0lxY96T/VIxlJe5Zu8WI3vu0ZQdrjd/sInySJKc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o1BMz-006v2z-Bh; Tue, 14 Jun 2022 20:34:29 +0200 Date: Tue, 14 Jun 2022 20:34:29 +0200 From: Andrew Lunn To: "Russell King (Oracle)" Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , "David S. Miller" , Eric Dumazet , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Robert Hancock , Vivien Didelot , Vladimir Oltean Subject: Re: [PATCH net-next 01/15] net: phylink: fix SGMII inband autoneg enable Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 13, 2022 at 02:00:25PM +0100, Russell King (Oracle) wrote: > When we are operating in SGMII inband mode, it implies that there is a > PHY connected, and the ethtool advertisement for autoneg applies to > the PHY, not the SGMII link. When in 1000base-X mode, then this applies > to the 802.3z link and needs to be applied to the PCS. > > Fix this. > > Fixes: 92817dad7dcb ("net: phylink: Support disabling autonegotiation for PCS") > Signed-off-by: Russell King (Oracle) Reviewed-by: Andrew Lunn Andrew