Content-Type: multipart/mixed; boundary="===============1143226497571369322==" MIME-Version: 1.0 From: Russell King (Oracle) To: kbuild-all@lists.01.org Subject: Re: [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig Date: Tue, 21 Jun 2022 08:08:29 +0100 Message-ID: In-Reply-To: <20220620174800.6dc60a5b@kernel.org> List-Id: --===============1143226497571369322== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jun 20, 2022 at 05:48:00PM -0700, Jakub Kicinski wrote: > On Tue, 21 Jun 2022 05:49:57 +0800 kernel test robot wrote: > > I love your patch! Yet something to improve: > > = > > [auto build test ERROR on net-next/master] > > = > > url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/n= et-pcs-xpcs-select-PHYLINK-in-Kconfig/20220621-042123 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.= git dbca1596bbb08318f5e3b3b99f8ca0a0d3830a65 > > config: i386-tinyconfig > > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > > reproduce (this is a W=3D1 build): > > # https://github.com/intel-lab-lkp/linux/commit/a3120516f7ee668= 96bb0d3c90fe653ce0cb3a09f > > git remote add linux-review https://github.com/intel-lab-lkp/li= nux > > git fetch --no-tags linux-review Jakub-Kicinski/net-pcs-xpcs-se= lect-PHYLINK-in-Kconfig/20220621-042123 > > git checkout a3120516f7ee66896bb0d3c90fe653ce0cb3a09f > > make W=3D1 ARCH=3Di386 tinyconfig > > make W=3D1 ARCH=3Di386 = > > = > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > > = > > All errors (new ones prefixed by >>): > > = > > >> drivers/net/phy/Kconfig:16:error: recursive dependency detected! = > > drivers/net/phy/Kconfig:16: symbol PHYLIB is selected by PHYLINK > > drivers/net/phy/Kconfig:6: symbol PHYLINK is selected by PCS_XPCS > > drivers/net/pcs/Kconfig:8: symbol PCS_XPCS depends on MDIO_DEVICE > > drivers/net/mdio/Kconfig:6: symbol MDIO_DEVICE is selected by PHYLIB > > For a resolution refer to Documentation/kbuild/kconfig-language.rst > > subsection "Kconfig recursive dependency limitations" > = > Dunno what the best practice is in that case :S > I'll leave this to the experts. Would it work to make all the PCS drivers depend on PHYLINK ? -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! --===============1143226497571369322==--