Date: Thu, 23 Jun 2022 18:17:30 +0200 From: frank@...2641... Message-ID: References: <20220512231901.1077306-1-heiko@...2662...> MIME-Version: 1.0 In-Reply-To: <20220512231901.1077306-1-heiko@...2662...> Subject: Re: [Openvpn-devel] [PATCH] make %x destination unsigned List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline To: openvpn-devel@lists.sourceforge.net Acked-By: Frank Lichtenheld Trivial and looks correct to me according to the man sscanf. On Fri, May 13, 2022 at 01:19:01AM +0200, Heiko Hund wrote: > The %x specifier requires for the argument to be an unsigned int. > > Signed-off-by: Heiko Hund > --- > src/openvpn/options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > index 9ff384d0..3dbd3fab 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -1104,7 +1104,7 @@ parse_hash_fingerprint(const char *str, int nbytes, int msglevel, struct gc_aren > ALLOC_OBJ_CLEAR_GC(ret, struct verify_hash_list, gc); > > char term = 0; > - int byte; > + unsigned int byte; > > while (*cp && i < nbytes) > { > -- > 2.32.0