Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1489C433EF for ; Fri, 24 Jun 2022 19:39:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E349D10E3AE; Fri, 24 Jun 2022 19:39:03 +0000 (UTC) Received: from mailrelay3-1.pub.mailoutpod1-cph3.one.com (mailrelay3-1.pub.mailoutpod1-cph3.one.com [46.30.210.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id D3CE810E47C for ; Fri, 24 Jun 2022 19:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=G2NikF/2bs7Kr25cPxu2AsOn40UQIgo3BOiq8YOvb8Y=; b=Owtz276RB1pcc6XNCAlxmcOjnXT8lwNRQ7zFZgZPQZm8e5ygnOjLgHd+57sA2VzLEok+NFmMRVnrQ 3s6yB6czKHPxBxkWKalgj5X69e4DWa5tt5xNNWdFL9RFepfwo8PBY/pHAPyL709CkqShWEceewoFmd HDZhXwPzYwq5SxLAhtUGUpJUy6LNob+jjxU72Yf8A8AQXDGcWeTqWj3zmIWzfK47sFllfWuNvx5kfe vMpNonAL+OPKkbwoHWAisuPCbe9TzYpwQ7vMwft5VkTYk6cE2TnR+81nZmERSoEWBmRlY5g+Ykvgjp cst+57DgXJxAbvtL2lFKeBo+n5+rx8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=G2NikF/2bs7Kr25cPxu2AsOn40UQIgo3BOiq8YOvb8Y=; b=pOBBjyIKONSdNiuZIGWP702qB1DINeFiRXXtBKJuY3WhP9ohK3i4yNx55RXFakaHBIh3Gqzap7pYb COnjVROCQ== X-HalOne-Cookie: 84d0f7bc642d4cc9db2f39a7067a35a84c26e651 X-HalOne-ID: 4bdb8468-f3f5-11ec-be7c-d0431ea8bb03 Received: from mailproxy3.cst.dirpod3-cph3.one.com (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 4bdb8468-f3f5-11ec-be7c-d0431ea8bb03; Fri, 24 Jun 2022 19:39:00 +0000 (UTC) Date: Fri, 24 Jun 2022 21:38:59 +0200 From: Sam Ravnborg To: Stephen Kitt Subject: Re: [PATCH v2 3/3] drm/panel: sony-acx565akm: Use backlight helpers Message-ID: References: <20220616172316.1355133-4-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616172316.1355133-4-steve@sk2.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , David Airlie , Sebastian Reichel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 16, 2022 at 07:23:15PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Instead of manually checking the power state in struct > backlight_properties, use backlight_is_blank(). > > While we're at it, drop .fb_blank from the initialisation function; it > is deprecated, and this helps make progress towards enabling its > removal. This change makes no functional difference since > FB_BLANK_UNBLANK is the default value. > > Signed-off-by: Stephen Kitt > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org Thanks, applied to drm-misc (drm-misc-next) Sam