Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73A54C43334 for ; Fri, 24 Jun 2022 19:40:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B527010E47C; Fri, 24 Jun 2022 19:40:06 +0000 (UTC) Received: from mailrelay3-1.pub.mailoutpod1-cph3.one.com (mailrelay3-1.pub.mailoutpod1-cph3.one.com [46.30.210.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA55810E47C for ; Fri, 24 Jun 2022 19:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=tb/2Dzr0y82HxvxdXbUrZlICLXG09leCUh4rUujWTew=; b=aamk3NGnyFLGuUV7zNrNuY2sut2/w9FUjuk+Y3fxli7PYfosW9Xjo3ZAxCo2YidR5o7wp3oVNcRSj LBbEnpif7o2zGEuy6bv/GrLyAXdZ61TVOzxVcHGrPwRcHL5NK8FLSIsfOvjsplm9DzT4RZx8MDzVBK PZwkAito8nufmJjk6YT16xGMos0XYPVQuve1c65uNS9gptT2+MSZQU3J+vqLr+RVKhakMO9YStVnth Q09Mdw7rxYqIZqRxwgNPpU6FuEUx3x1Usi6cfpuH/qN9NkWBuWsveknfrzPFzX0FIMcuYUf5qAcP2+ 48e6H3l3QY+OET4SUftvuwWZNg8IaFA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=tb/2Dzr0y82HxvxdXbUrZlICLXG09leCUh4rUujWTew=; b=XujhgoFv1EbT5vPXPuUikFZmXejWuleWrHpcUx7a/XOViOqjzILy0JcIlNI304dGQrvhP6fNfm6gH sDuaYHYDg== X-HalOne-Cookie: 85d8e3b2b13cf959bb177e8137e5e1ee09d0b1e4 X-HalOne-ID: 70bf7d90-f3f5-11ec-be7c-d0431ea8bb03 Received: from mailproxy1.cst.dirpod3-cph3.one.com (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 70bf7d90-f3f5-11ec-be7c-d0431ea8bb03; Fri, 24 Jun 2022 19:40:02 +0000 (UTC) Date: Fri, 24 Jun 2022 21:40:01 +0200 From: Sam Ravnborg To: Stephen Kitt Subject: Re: [PATCH v2 2/3] drm/panel: panel-dsi-cm: Use backlight helpers Message-ID: References: <20220616172316.1355133-3-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616172316.1355133-3-steve@sk2.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , David Airlie , Sebastian Reichel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 16, 2022 at 07:23:14PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Instead of setting the power state by manually updating fields in > struct backlight_properties, use backlight_enable() and > backlight_disable(). These also call backlight_update_status() so the > separate call is no longer needed. > > Signed-off-by: Stephen Kitt > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org Thanks, applied to drm-misc (drm-misc-next) Sam