Date: Mon, 4 Jul 2022 10:47:13 +0200 From: Frank Lichtenheld Message-ID: References: <20220624083809.23487-1-a@...2181...> <20220624083809.23487-18-a@...2181...> MIME-Version: 1.0 In-Reply-To: <20220624083809.23487-18-a@...2181...> Subject: Re: [Openvpn-devel] [PATCH 17/25] tun: extract close_tun_handle into its own fucntion and print correct type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline To: Antonio Quartulli Cc: openvpn-devel@lists.sourceforge.net On Fri, Jun 24, 2022 at 10:38:01AM +0200, Antonio Quartulli wrote: > From: Arne Schwabe > > This moves closing the tun handle into its own function and also prints > the adapter type we are operating on, instead hardcoding it to > tap-windows. > > While at it, set the handle to NULL after closing, to prevent a double > close due to multiple invocations of this helper. > > Signed-off-by: Arne Schwabe > Signed-off-by: Antonio Quartulli > --- > src/openvpn/tun.c | 76 ++++++++++++++++++++++++++--------------------- > 1 file changed, 42 insertions(+), 34 deletions(-) Trivial enough. Also can be applied independently of all changes before it in the series! Acked-By: Frank Lichtenheld Regards, -- Frank Lichtenheld