Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1200DC433EF for ; Mon, 4 Jul 2022 11:22:36 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 799491713; Mon, 4 Jul 2022 13:21:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 799491713 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1656933754; bh=54G0TnkyP3R/V8HJ55+lpVcBMr9dRxIZvwXjUc/RfmY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UM3LbkyLYfoVuw1fJ1qAhV3vd5SpTJAe2b18+wxH34vBCqPinK1ShOrPHgcORIJq1 qp29vt4x4jUVHwQcX0ccU6CyuT4RKJfSyC/Hv6iqzPVHFg8NgukLQcZgG3x/K3UaCT vpFqEgt1HnLGDNXEZS77T73pTdB/If1wU4s1CYZE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0D850F800ED; Mon, 4 Jul 2022 13:21:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4C48BF8014E; Mon, 4 Jul 2022 13:21:43 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 151E0F800ED for ; Mon, 4 Jul 2022 13:21:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 151E0F800ED Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bsMg+1nN" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B4AF4B80ECF; Mon, 4 Jul 2022 11:21:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A9ABC3411E; Mon, 4 Jul 2022 11:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656933698; bh=54G0TnkyP3R/V8HJ55+lpVcBMr9dRxIZvwXjUc/RfmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bsMg+1nNSbZ0ds8EUOpB2EK0KIXuT+zkJRlJFa+WBg3sPTe1CH4Zy0zuET/dNVv/J 2mS/qUZd+Sa9e95bjch0pRqLpvEKBxilUnA2nPvPdnShVMPMiM0xSkvkvfrgmRSh34 SFBgo+UgUzHIMieyPeSwqORy0clK+xrrLd3mwej2/hIpnxzA2bWjtOMMBixuUuCJyk ummwvgoV0hXTN2rB3+Bv3mFPZywPWKrngXb6gAnKZsQOpsuO6B1d2zXEcXeCsprB+N MEi/aRZoFhtaL4n4S7DYDKG+YIiv4SIU4rzbIx10ykR0Cb0HDwTvEmnzoxoMoxp8RL i1X4ndXI5S5Ew== Date: Mon, 4 Jul 2022 12:21:33 +0100 From: Mark Brown To: Liang He Subject: Re: [PATCH] sound: qcom: Fix missing of_node_put() in asoc_qcom_lpass_cpu_platform_probe() Message-ID: References: <20220702020109.263980-1-windhl@126.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vv7KQyG7fjVMMpCV" Content-Disposition: inline In-Reply-To: <20220702020109.263980-1-windhl@126.com> X-Cookie: MERYL STREEP is my obstetrician! Cc: alsa-devel@alsa-project.org, bgoswami@codeaurora.org, tiwai@suse.com, lgirdwood@gmail.com, srinivas.kandagatla@linaro.org, linmq006@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --vv7KQyG7fjVMMpCV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jul 02, 2022 at 10:01:09AM +0800, Liang He wrote: > We should call of_node_put() for the reference 'dsp_of_node' returned by > of_parse_phandle() which will increase the refcount. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. --vv7KQyG7fjVMMpCV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLCzTwACgkQJNaLcl1U h9CVjQf/Yo5Yr/xqNFXCTcfhWs32jaM5WoATcxPluLUk1qLv7dstAUnF+xjLoLht OIk1tnOnB5xUrIHP1TzB1EG6xBzdGZyoX/WVpvWUgObmuZZMgOPZV7VgrafEZ9oD cxnPLU0tlctu4rfN1cVaAub/04BDarDNrkAa/BXLBsut0FQ+kM1F9cobf/zr6nEd r1Qu0R5qC3NvS7c21vhebjDv/Y7PUzH4U3cVb2NbyUEATErAhb1D6+J4h6f6x9wi ThHwseLpRSiTKVUJajD0fkJsg4oS7+UJEKQOUkDjmZnNR0gcNFrn8SMh19qSzZDu jsImdimn1FCzAe6Gg1APzps0sKLqkA== =wHQj -----END PGP SIGNATURE----- --vv7KQyG7fjVMMpCV--